-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update node to v20 lts #1688
update node to v20 lts #1688
Conversation
c98f914
to
3064792
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1688 +/- ##
=======================================
Coverage 61.47% 61.47%
=======================================
Files 132 132
Lines 2998 2998
Branches 757 757
=======================================
Hits 1843 1843
Misses 1038 1038
Partials 117 117 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
97b37c3
to
7c754ab
Compare
@@ -6,7 +6,7 @@ interface Context { | |||
client: ReturnType<typeof createAdminClient> | |||
} | |||
|
|||
describe<Context>('Admin Client', (adminClient) => { | |||
describe.skip<Context>('Admin Client', (adminClient) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you skip this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reworked the whole thing, tests are fixed.
frontend/e2e/screenshot-firefox.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does firefox show only one comment? I see that other browsers render 5 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, those shouldn't get into the repo.
Those were created while local testing and FF had some problems.
7520aed
to
0d5dc90
Compare
Pull Request Test Coverage Report for Build 7623478702
💛 - Coveralls |
e289826
to
f18152b
Compare
f18152b
to
34cb9fd
Compare
".": { | ||
"import": "./dist/index.js", | ||
"require": "./dist/index.js", | ||
"types": "./dist/index.d.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://nodejs.org/api/packages.html#community-conditions-definitions
"types" - can be used by typing systems to resolve the typing file for the given export. This condition should always be included first.
// overrides type of init in URLSearchParams constructor because it's not correct and accepts QueryParams | ||
const searchParams = new URLSearchParams( | ||
Object.entries(query).reduce<Record<string, string>>( | ||
(acc, [k, v]) => Object.assign(acc, { [k]: v.toString() }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to create new object on every iterations and we can mutate acc
acc[k] = v.toString();
34cb9fd
to
adf13ff
Compare
adf13ff
to
6917ad0
Compare
package.json