-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ui error when no auth providers configured #1640
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 61.55% 61.57% +0.02%
==========================================
Files 133 133
Lines 3004 3006 +2
Branches 752 761 +9
==========================================
+ Hits 1849 1851 +2
- Misses 1038 1151 +113
+ Partials 117 4 -113
☔ View full report in Codecov by Sentry. |
e804e42
to
ee2c352
Compare
ee2c352
to
74fd5a8
Compare
@@ -65,4 +65,8 @@ export const messages = defineMessages<string>({ | |||
id: 'auth.signout', | |||
defaultMessage: 'Sign Out', | |||
}, | |||
noProviders: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add a translation string and regenerate translations in case you're adding new text like that.
@Jaskon can you please finalise that PR so that we could merge it? |
This issue
Please correct me if i'm wrong: view variable (telegram/token/email) is only exist after some action in the dropdown menu. So its not necessary to check here that view is equal to something and checks provided in my PR is enough