-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix webworker not working #12795
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
稍等我试试看能不能补充一个 example |
packages/bundler-webpack/src/plugins/RuntimePublicPathPlugin.ts
Outdated
Show resolved
Hide resolved
ready~ |
还有其他人能看下? |
@Wxh16144 能换个其他人 review 吗? |
你可以自己先用 package-patch 方式修改 node_modules 跑吧。 不知道等到什么时候呢 |
c93a112
to
603860e
Compare
603860e
to
8d2a37c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12795 +/- ##
==========================================
- Coverage 27.86% 27.86% -0.01%
==========================================
Files 500 500
Lines 15830 15831 +1
Branches 3828 3829 +1
==========================================
Hits 4411 4411
- Misses 10610 10611 +1
Partials 809 809 ☔ View full report in Codecov by Sentry. |
不搞了,交给有缘人修复吧~ |
fix #12781
原因是 worker 环境中, globalThis 和 宿主的不是同一个,不能直接使用。多加一层判断。
先决条件: