-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check bundler before apply styled babel plugin #11861
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size Change: +69 B (0%) Total Size: 9.89 MB
ℹ️ View Unchanged
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11861 +/- ##
==========================================
- Coverage 28.92% 28.89% -0.03%
==========================================
Files 488 488
Lines 14877 14891 +14
Branches 3535 3537 +2
==========================================
Hits 4303 4303
- Misses 9816 9828 +12
- Partials 758 760 +2
☔ View full report in Codecov by Sentry. |
找个地方统一处理下那些 mako 不支持的 umi 配置是不是更好,比如统一剔除掉 |
三方 Umi 插件或用户配置里存在 babel 插件的话,是期望给出警告的,因为无法评估缺少 babel 插件对产物是否有影响 |
* feat: check bundler before apply styled babel plugin * refactor: correct type
仅在 webpack 和 vite 构建器时应用 styled-componets 的 babel 插件,因为 Mako 不支持 babel 插件避免抛出警告,未来会以其他方式支持 styled-components babel 插件提供的能力