fix: 在有basename的情况下__serverLoader的请求路径需要加上basename #11739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: chencheng (云谦) <[email protected]>
以解决 react-dom/server renderToReadableStream 不存在的问题
… Workers的平台" This reverts commit 5b0946a.
Co-authored-by: 咲奈Sakina <[email protected]>
Co-authored-by: 咲奈Sakina <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11739 +/- ##
=======================================
Coverage 28.94% 28.94%
=======================================
Files 485 485
Lines 14774 14774
Branches 3501 3502 +1
=======================================
Hits 4276 4276
Misses 9738 9738
Partials 760 760
☔ View full report in Codecov by Sentry. |
fz6m
reviewed
Oct 15, 2023
| @@ -265,7 +265,8 @@ const getBrowser = ( | |||
| // server loader | |||
| // use ?. since routes patched with patchClientRoutes is not exists in opts.routes | |||
| if (!isFirst && opts.routes[id]?.hasServerLoader) { | |||
| fetch('/__serverLoader?route=' + id) | |||
| // 在有basename的情况下__serverLoader的请求路径需要加上basename | |||
| fetch((basename.endsWith('/') ? basename : basename + '/') + '__serverLoader?route=' + id) | |||
There was a problem hiding this comment.
fetch(`${withEndSlash(basename)}__serverLoader?route=${id}`)
function withEndSlash(s: string) {
return s.endsWith('/') ? s : `${s}/`
}
sorrycc
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.