Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: SSR模式下，多输出一份和index.html完全一致的*.html文件，用于ER场景 #11723

Merged
merged 20 commits into from
Oct 11, 2023
Merged

feature: SSR模式下，多输出一份和index.html完全一致的*.html文件，用于ER场景 #11723

Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
53f38f2
fix: dev环境构建SSR server.js时，环境判断错误导致输出的dev产物带上了hash
Oct 8, 2023
7f6d6d5
Update packages/preset-umi/src/features/ssr/webpack/webpack.ts
gwuhaolin Oct 8, 2023
5d004a1
fix: dev环境构建SSR server.js时，环境判断错误导致输出的dev产物带上了hash
Oct 8, 2023
3fc62cf
Merge branch 'umijs:master' into master
gwuhaolin Oct 9, 2023
5b0946a
feature: 支持自定义SSR构建目标，默认为node，可配置为webworker以支持运行在类似Cloudflare Workers的平台
Oct 9, 2023
7fe8bdc
feature: getManifest支持传入sourceDir表示SSR产物目录
Oct 9, 2023
542304a
feature: getManifest支持传入sourceDir表示SSR产物目录
Oct 9, 2023
335e6a6
fix: rendertoreadablestream is not a function
Oct 9, 2023
e7fb0c1
Revert "feature: 支持自定义SSR构建目标，默认为node，可配置为webworker以支持运行在类似Cloudflare…
Oct 9, 2023
64a9a42
fix: rendertoreadablestream is not a function
Oct 9, 2023
bfcd087
Update packages/server/src/ssr.ts
gwuhaolin Oct 10, 2023
d1a6e33
Update packages/server/src/ssr.ts
gwuhaolin Oct 10, 2023
e9ced7f
fix: 还原g_getAssets
Oct 10, 2023
a496ec7
Merge branch 'umijs:master' into master
gwuhaolin Oct 10, 2023
1ab01c4
fix: 被执行时才调用getManifest()，避免在入口立即调用getManifest()
Oct 10, 2023
af6b87f
fix: 被执行时才调用getManifest()，避免在入口立即调用getManifest()
Oct 10, 2023
aceacd1
fix: 被执行时才调用getManifest()，避免在入口立即调用getManifest()
Oct 10, 2023
0f9f649
Merge branch 'umijs:master' into master
gwuhaolin Oct 11, 2023
a55b708
feature: SSR模式下，多输出一份和index.html完全一致的*.html文件，用于ER场景
Oct 11, 2023
d572247
feature: SSR模式下，多输出一份和index.html完全一致的*.html文件，用于ER场景
Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/preset-umi/src/features/ssr/ssr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ export default function handler(request, response) {
}
});

api.onBuildHtmlComplete(() => {
// SSR模式下，多输出一份和index.html完全一致的*.html文件，用于ER场景
fsExtra.copyFileSync(join(api.paths.absOutputPath, 'index.html'), join(api.paths.absOutputPath, '*.html'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方非常不清真。

  1. 首先这是用户非预期的文件，我们不应该生成大部分用户不需要的文件，这部分特定于 serverless 的可以做到 bigfish 里或者单独的 serverless plugin 或 preset 里去，而不应该污染源代码库造成所有人都有这个副作用。

  2. 其次有的人可能对 html 产物做了修改，这里复制了 index.html 其实用户会得到两个不一样的 html 产物，会造成非常大的疑惑，是黑盒。

  3. 另外标准存在不一致，社区内对于 404 fallback 的默认行为是 找不到会使用 404.html ，而这里是 *.html ，不符合社区共识。

改进意见

  1. 做到 bigfish 中或内部自己的 serverless umi plugin or preset 中，不要污染 umi 代码仓库造成所有人的副作用和非预期黑盒产物。

或

  1. 新增选项 ssr: { er: true } 选项来开启这个生成功能，以后所有的副作用做到这个选项开启内。

})

const pluginName = 'ProcessAssetsPlugin';
class ProcessAssetsPlugin {
apply(compiler: Compiler) {
Expand Down