feat: support output bundler unminified #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachScript
reviewed
Aug 22, 2024
| filename: | ||
| output.filename || `${getAutoBundleFilename(pkg.name)}.min.js`, | ||
| // default to output dist | ||
| path: output.path || 'dist/umd', |
src/builder/config.ts
Outdated
| const entryOutput = | ||
| typeof outputConfig === 'object' | ||
| ? outputConfig | ||
| : { path: outputConfig }; | ||
|
|
||
| configs.push({ | ||
| const unminifiedConfig = { |
There was a problem hiding this comment.
如果没有 generateUnminified 就没必要生成对应配置吧，感觉流程上还是这样清晰？
configs.push(/* 压缩配置 */);
if (generateUnminified) {
configs.push(/* 非压缩配置 */)
}
PeachScript
reviewed
Aug 22, 2024
boilerplate/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "create-father", | |||
| "version": "4.5.0", | |||
| "version": "4.5.1-beta.3", | |||
| filename: output.filename | ||
| ? `${output.filename}.js` | ||
| : `${defaultFileName}.js`, | ||
| path: output.path || 'dist/umd', |
There was a problem hiding this comment.
这个默认值还是写了多次；可以 bundlerConfig.output.path 有个默认值，后续各配置生成的时候优先取配置里的，兜底到默认值
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.