Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/prometheus/client_golang from 1.18.0 to 1.20.2 #2597

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Bumps github.com/prometheus/client_golang from 1.18.0 to 1.20.2.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.20.2

  • [BUGFIX] promhttp: Unset Content-Encoding header when data is uncompressed. #1596

v1.20.1

This release contains the critical fix for the issue. Thanks to @​geberl, @​CubicrootXYZ, @​zetaab and @​timofurrer for helping us with the investigation!

  • [BUGFIX] process-collector: Fixed unregistered descriptor error when using process collector with PedanticRegistry on Linux machines. #1587

v1.20.0

Thanks everyone for contributions!

⚠️ In this release we remove one (broken anyway, given Go runtime changes) metric and add three new (representing GOGC, GOMEMLIMIT and GOMAXPROCS flags) to the default collectors.NewGoCollector() collector. Given its popular usage, expect your binary to expose two additional metric.

Changes

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #1568 #1578
  • [FEATURE] testutil: Add CollectAndFormat method. #1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #1424

... (truncated)

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.20.2 / 2024-08-23

  • [BUGFIX] promhttp: Unset Content-Encoding header when data is uncompressed. #1596

1.20.1 / 2024-08-20

  • [BUGFIX] process-collector: Fixed unregistered descriptor error when using process collector with PedanticRegistry on linux machines. #1587

1.20.0 / 2024-08-14

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #1568 #1578
  • [FEATURE] testutil: Add CollectAndFormat method. #1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #1537
  • [FEATURE] process-collector: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #1424

1.19.0 / 2024-02-27

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427
Commits
  • 67121dc Merge pull request #1596 from mrueg/fix-uncompressed-content-header
  • 187acd4 Cut 1.20.2
  • f7f8f3a fix: Unset Content-Encoding header when uncompressed
  • 2254d6c Merge pull request #1587 from prometheus/fix-processcollector
  • 4a15d05 Cut 1.20.1
  • f2dd7b3 Use pedantic registry in other places too, to double check.
  • 261fe84 bugfix: Pass network metrics to processCollector's Describe() function
  • 5bf3341 Use NewPedanticRegistry in Process' Collector tests
  • 73b811c Cut 1.20.0 release. (#1580)
  • 7ce5089 gocollector: Attach original runtime/metrics metric name to help. (#1578)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • New Features
    • Updated dependencies to enhance functionality and performance, including significant upgrades to Prometheus-related packages.
  • Bug Fixes
    • Potential bug fixes and optimizations included in the updated versions of several libraries.
  • Chores
    • Improved stability and performance through comprehensive dependency management updates.

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.20.2.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.18.0...v1.20.2)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor

coderabbitai bot commented Aug 26, 2024

Walkthrough

The go.mod file has been updated to reflect several dependency version upgrades, enhancing the project's library management. Key updates include the Prometheus libraries and golang.org/x/oauth2, with the addition of a new indirect dependency, github.com/munnerz/goautoneg. These changes indicate a comprehensive update to improve the project's stability and performance.

Changes

Files/Dependencies Change Summary
github.com/prometheus/client_golang v1.18.0 → v1.20.2
github.com/klauspost/compress v1.17.2 → v1.17.9
github.com/prometheus/client_model, v0.5.0 → v0.6.1
github.com/prometheus/common, v0.45.0 → v0.55.0
github.com/prometheus/procfs v0.12.0 → v0.15.1
golang.org/x/oauth2 v0.20.0 → v0.21.0
github.com/munnerz/goautoneg New indirect dependency added

Sequence Diagram(s)

sequenceDiagram
    participant A as Application
    participant B as Prometheus Client
    participant C as OAuth2
    participant D as New Dependency

    A->>B: Request Metrics
    B-->>A: Return Metrics
    A->>C: Authenticate User
    C-->>A: Return Token
    A->>D: Use New Feature
    D-->>A: Return Feature Response
Loading

Poem

🐇 In the meadow, changes bloom,
Dependencies dance, dispelling gloom.
With Prometheus and OAuth in tow,
Our project leaps, ready to grow!
A hop, a skip, a joyful cheer,
New features come, the future is near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dddb9ed and 06c7787.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (6 hunks)
Additional comments not posted (7)
go.mod (7)

175-175: Verify compatibility with the new version.

The github.com/prometheus/client_model dependency has been updated from v0.5.0 to v0.6.1. Ensure that the new version is compatible with the existing codebase.

Run the following script to verify the usage of this dependency:


165-165: Verify compatibility with the new dependency.

The github.com/munnerz/goautoneg dependency has been added as a new indirect dependency. Ensure that the new dependency does not introduce any conflicts.

Run the following script to verify the usage of this dependency:

Verification successful

Dependency is correctly managed as a transitive dependency.

The github.com/munnerz/goautoneg dependency is listed in the go.sum file, confirming its status as a transitive dependency. There is no direct usage in the codebase, indicating that it is managed correctly by Go's module system without introducing conflicts.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `github.com/munnerz/goautoneg` in the codebase.

# Test: Search for the usage of the dependency. Expect: No conflicts.
rg --type go 'github.com/munnerz/goautoneg'

Length of output: 43


Script:

#!/bin/bash
# Check if `github.com/munnerz/goautoneg` is listed in the go.sum file, indicating it's a transitive dependency.
rg 'github.com/munnerz/goautoneg' go.sum

Length of output: 271


146-146: Verify compatibility with the new version.

The github.com/klauspost/compress dependency has been updated from v1.17.2 to v1.17.9. Ensure that the new version is compatible with the existing codebase.

Run the following script to verify the usage of this dependency:


176-176: Verify compatibility with the new version.

The github.com/prometheus/common dependency has been updated from v0.45.0 to v0.55.0. Ensure that the new version is compatible with the existing codebase.

Run the following script to verify the usage of this dependency:


177-177: Verify compatibility with the new version.

The github.com/prometheus/procfs dependency has been updated from v0.12.0 to v0.15.1. Ensure that the new version is compatible with the existing codebase.

Run the following script to verify the usage of this dependency:


210-210: Verify compatibility with the new version.

The golang.org/x/oauth2 dependency has been updated from v0.20.0 to v0.21.0. Ensure that the new version is compatible with the existing codebase.

Run the following script to verify the usage of this dependency:

Verification successful

No direct usage of golang.org/x/oauth2 found in the codebase.

The golang.org/x/oauth2 dependency is marked as "indirect" and is not directly used in the codebase. The update to version v0.21.0 should not affect the codebase directly. Ensure that any packages relying on this dependency are compatible with the update.

  • golang.org/x/oauth2 is confirmed in go.sum but not directly used in the codebase.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `golang.org/x/oauth2` in the codebase.

# Test: Search for the usage of the dependency. Expect: No breaking changes.
rg --type go 'golang.org/x/oauth2'

Length of output: 34


Script:

#!/bin/bash
# Check for the presence of `golang.org/x/oauth2` in go.sum
rg 'golang.org/x/oauth2' go.sum

# Search for any indirect usage of `golang.org/x/oauth2` in the codebase
rg 'oauth2' --type go

Length of output: 2934


26-26: Verify compatibility with the new version.

The github.com/prometheus/client_golang dependency has been updated from v1.18.0 to v1.20.2. Ensure that the new version is compatible with the existing codebase.

Run the following script to verify the usage of this dependency:

Verification successful

Compatibility with the new version is likely maintained.

The github.com/prometheus/client_golang dependency update from v1.18.0 to v1.20.2 involves the use of prometheus.DefaultRegisterer in cmd/umeed/cmd/app_creator.go. This is a standard usage pattern, and no breaking changes are expected. However, reviewing the release notes for any specific changes related to DefaultRegisterer is recommended.

  • File: cmd/umeed/cmd/app_creator.go
  • Usage: wasmkeeper.WithVMCacheMetrics(prometheus.DefaultRegisterer)
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `github.com/prometheus/client_golang` in the codebase.

# Test: Search for the usage of the dependency. Expect: No breaking changes.
rg --type go 'github.com/prometheus/client_golang'

Length of output: 129


Script:

#!/bin/bash
# Extract and review the relevant code sections in `cmd/umeed/cmd/app_creator.go` where `github.com/prometheus/client_golang/prometheus` is used.
rg --type go --context 5 'github.com/prometheus/client_golang/prometheus' cmd/umeed/cmd/app_creator.go

Length of output: 562


Script:

#!/bin/bash
# Search for the usage of Prometheus-related functions or features in `cmd/umeed/cmd/app_creator.go`.
rg --type go 'prometheus\.' cmd/umeed/cmd/app_creator.go

Length of output: 149

@gsk967
Copy link
Collaborator

gsk967 commented Aug 27, 2024

This pr is braking the build process

RocksDB support is disabled; to build and test with RocksDB support, set ENABLE_ROCKSDB=true
go build -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=umee -X github.com/cosmos/cosmos-sdk/version.AppName=umeed -X github.com/cosmos/cosmos-sdk/version.Version=6.6.0-11-g06c7787f -X github.com/cosmos/cosmos-sdk/version.Commit=06c7787f3e309d9c236bcb8cfe59782a9ccf74d2 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -X github.com/cometbft/cometbft/version.TMCoreSemVer=v0.37.10 -w -s' -trimpath -o /Users/gsk967/Projects/umee-network/umee/build/ ./...
go: downloading github.com/prometheus/client_golang v1.20.2
# github.com/cosmos/cosmos-sdk/telemetry
../../../go/pkg/mod/github.com/cosmos/[email protected]/telemetry/metrics.go:156:37: undefined: expfmt.FmtText
../../../go/pkg/mod/github.com/cosmos/[email protected]/telemetry/metrics.go:163:51: undefined: expfmt.FmtText
make: *** [build] Error 1

@gsk967 gsk967 closed this Aug 27, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 27, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.20.2 branch August 27, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant