chore: remove repeat word #2538
Conversation
Signed-off-by: costcould <[email protected]>
WalkthroughThe recent changes primarily involve the enhancement and bug fixes of various Bash scripts and Go files. The updates include typo corrections, comment improvements, and the addition of new functionalities within scripts for checking text patterns and cloning repositories. Overall, the changes aim to improve script accuracy, maintainability, and functionality without altering the core declarations of the exported or public entities. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 10
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- check_a_or_an.sh (1 hunks)
- check_dup_word.sh (1 hunks)
- check_html_tag.sh (1 hunks)
- get_all_eth.sh (1 hunks)
- get_all_go.sh (1 hunks)
- get_all_rust.sh (1 hunks)
- x/incentive/keeper/scenario_test.go (1 hunks)
- x/leverage/types/keys.go (1 hunks)
- x/leverage/types/token.go (1 hunks)
- x/uibc/quota/quota_test.go (1 hunks)
Files skipped from review due to trivial changes (6)
- check_dup_word.sh
- check_html_tag.sh
- x/incentive/keeper/scenario_test.go
- x/leverage/types/keys.go
- x/leverage/types/token.go
- x/uibc/quota/quota_test.go
Additional context used
Shellcheck
check_a_or_an.sh
[error] 10-10: Double quote array expansions to avoid re-splitting elements. (SC2068)
[info] 12-12: Double quote to prevent globbing and word splitting. (SC2086)
[error] 28-28: Double quote array expansions to avoid re-splitting elements. (SC2068)
[info] 30-30: Double quote to prevent globbing and word splitting. (SC2086)
get_all_rust.sh
[warning] 5-5: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
[warning] 8-8: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
get_all_eth.sh
[warning] 4-4: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
[warning] 7-7: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
get_all_go.sh
[warning] 4-4: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
[warning] 7-7: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
|
|
||
| for item in ${not_a_array[@]} | ||
| do | ||
| ag "a "$item |
There was a problem hiding this comment.
Double quote the pattern in ag command to prevent globbing and word splitting.
- ag "a "$item
+ ag "a $item"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ag "a "$item | |
| ag "a $item" |
Tools
Shellcheck
[info] 30-30: Double quote to prevent globbing and word splitting. (SC2086)
|
|
||
| for item in ${not_an_array[@]} | ||
| do | ||
| ag "an "$item |
There was a problem hiding this comment.
Double quote the pattern in ag command to prevent globbing and word splitting.
- ag "an "$item
+ ag "an $item"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ag "an "$item | |
| ag "an $item" |
Tools
Shellcheck
[info] 12-12: Double quote to prevent globbing and word splitting. (SC2086)
| not_an_array=(user utility unique useful url union uvarint uniform usage uid unified utilization unit unix utilized usual uintptr uint) | ||
|
|
||
|
|
||
| for item in ${not_an_array[@]} |
There was a problem hiding this comment.
Ensure array expansions are double-quoted to prevent word splitting.
- for item in ${not_an_array[@]}
+ for item in "${not_an_array[@]}"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| for item in ${not_an_array[@]} | |
| for item in "${not_an_array[@]}" |
Tools
Shellcheck
[error] 10-10: Double quote array expansions to avoid re-splitting elements. (SC2068)
| not_a_array=(http heir herb honest honesty honorable hour honor MBA FBI herb hypothesis historic hourglass xml) | ||
|
|
||
|
|
||
| for item in ${not_a_array[@]} |
There was a problem hiding this comment.
Ensure array expansions are double-quoted to prevent word splitting.
- for item in ${not_a_array[@]}
+ for item in "${not_a_array[@]}"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| for item in ${not_a_array[@]} | |
| for item in "${not_a_array[@]}" |
Tools
Shellcheck
[error] 28-28: Double quote array expansions to avoid re-splitting elements. (SC2068)
| cd ~ | ||
| mkdir new-rust | ||
|
|
||
| cd new-rust |
There was a problem hiding this comment.
Add error handling for cd command to ensure script exits if directory change fails.
- cd new-rust
+ cd new-rust || exitCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| cd new-rust | |
| cd new-rust || exit |
Tools
Shellcheck
[warning] 8-8: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
|
|
||
|
|
||
| #cd /Users/fliter | ||
| cd ~ |
There was a problem hiding this comment.
Add error handling for cd command to ensure script exits if directory change fails.
- cd ~
+ cd ~ || exitCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| cd ~ | |
| cd ~ || exit |
Tools
Shellcheck
[warning] 5-5: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
| cd ~ | ||
| mkdir new-eth | ||
|
|
||
| cd new-eth |
There was a problem hiding this comment.
Add error handling for cd command to ensure script exits if directory change fails.
- cd new-eth
+ cd new-eth || exitCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| cd new-eth | |
| cd new-eth || exit |
Tools
Shellcheck
[warning] 7-7: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
| #!/bin/bash | ||
|
|
||
| #cd /Users/fliter | ||
| cd ~ |
There was a problem hiding this comment.
Add error handling for cd command to ensure script exits if directory change fails.
- cd ~
+ cd ~ || exitCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| cd ~ | |
| cd ~ || exit |
Tools
Shellcheck
[warning] 4-4: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
| cd ~ | ||
| mkdir new-go | ||
|
|
||
| cd new-go |
There was a problem hiding this comment.
Add error handling for cd command to ensure script exits if directory change fails.
- cd new-go
+ cd new-go || exitCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| cd new-go | |
| cd new-go || exit |
Tools
Shellcheck
[warning] 7-7: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
| #!/bin/bash | ||
|
|
||
| #cd /Users/fliter | ||
| cd ~ |
There was a problem hiding this comment.
Add error handling for cd command to ensure script exits if directory change fails.
- cd ~
+ cd ~ || exitCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| cd ~ | |
| cd ~ || exit |
Tools
Shellcheck
[warning] 4-4: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (SC2164)
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Thanks. The new pr #2579 Please review again. |
Description
remove repeat word
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
Bug Fixes