Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: x/metoken balances and prices query improvements #2198

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

kosegor
Copy link
Contributor

@kosegor kosegor commented Aug 16, 2023

@kosegor kosegor marked this pull request as ready for review August 16, 2023 18:22
@kosegor kosegor requested a review from a team as a code owner August 16, 2023 18:22
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2198 (4b7f8b6) into main (7f05ad4) will decrease coverage by 5.27%.
Report is 184 commits behind head on main.
The diff coverage is 79.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2198      +/-   ##
==========================================
- Coverage   75.38%   70.12%   -5.27%     
==========================================
  Files         100      166      +66     
  Lines        8025    12615    +4590     
==========================================
+ Hits         6050     8846    +2796     
- Misses       1589     3177    +1588     
- Partials      386      592     +206     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/reward.go 82.35% <ø> (ø)
x/incentive/keeper/store.go 70.67% <ø> (ø)
x/incentive/keeper/unbonding.go 80.45% <ø> (ø)
x/incentive/keeper/update.go 52.11% <ø> (ø)
x/incentive/keys.go 100.00% <ø> (ø)
... and 59 more

... and 68 files with indirect coverage changes

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Pre Approving
Small nit can you look into those comments

proto/umee/metoken/v1/metoken.proto Show resolved Hide resolved
proto/umee/metoken/v1/query.proto Show resolved Hide resolved
proto/umee/metoken/v1/query.proto Show resolved Hide resolved
proto/umee/metoken/v1/query.proto Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change the PriceByBaseDenom api

proto/umee/metoken/v1/metoken.proto Outdated Show resolved Hide resolved
proto/umee/metoken/v1/metoken.proto Outdated Show resolved Hide resolved
x/metoken/price.go Outdated Show resolved Hide resolved
@kosegor kosegor enabled auto-merge August 17, 2023 17:11
@kosegor kosegor added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit e4ef22a Aug 17, 2023
@kosegor kosegor deleted the egor/metoken-fe-qry branch August 17, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants