-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: x/metoken balances and prices query improvements #2198
Conversation
kosegor
commented
Aug 16, 2023
•
edited
Loading
edited
- Amplifying both queries with some additional information was requested from the FE: https://linear.app/umee/issue/UMEE-808/metoken-query-changes-for-frontend
Codecov Report
@@ Coverage Diff @@
## main #2198 +/- ##
==========================================
- Coverage 75.38% 70.12% -5.27%
==========================================
Files 100 166 +66
Lines 8025 12615 +4590
==========================================
+ Hits 6050 8846 +2796
- Misses 1589 3177 +1588
- Partials 386 592 +206
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Pre Approving
Small nit can you look into those comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change the PriceByBaseDenom
api
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>