Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow the duplicate symbols on leverage token registry #2197

Merged
merged 6 commits into from
Aug 19, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Aug 16, 2023

Description

  1. Now we are allowing duplicate symbol denoms to leverage token registry (like KAVA USDT, Axelar USDT both have USDT same symbol denom)
  2. Fix the miss counter increasing for duplicate symbol register on oracle acceptList

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2197 (3ece772) into main (7f05ad4) will decrease coverage by 5.27%.
Report is 185 commits behind head on main.
The diff coverage is 79.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
- Coverage   75.38%   70.12%   -5.27%     
==========================================
  Files         100      166      +66     
  Lines        8025    12614    +4589     
==========================================
+ Hits         6050     8845    +2795     
- Misses       1589     3177    +1588     
- Partials      386      592     +206     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/reward.go 82.35% <ø> (ø)
x/incentive/keeper/store.go 70.67% <ø> (ø)
x/incentive/keeper/unbonding.go 80.45% <ø> (ø)
x/incentive/keeper/update.go 52.11% <ø> (ø)
x/incentive/keys.go 100.00% <ø> (ø)
... and 59 more

... and 69 files with indirect coverage changes

@gsk967 gsk967 marked this pull request as ready for review August 16, 2023 16:29
@gsk967 gsk967 requested review from a team as code owners August 16, 2023 16:29
@gsk967 gsk967 changed the title fix(WIP): allow the duplicate symbols on leverage token registry fix: allow the duplicate symbols on leverage token registry Aug 16, 2023
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's validate it with the Oracle team. I think we are missing symbol denom checks in oracle/abci.go

x/oracle/abci.go Show resolved Hide resolved
@gsk967 gsk967 requested a review from a team as a code owner August 17, 2023 12:17
CHANGELOG.md Show resolved Hide resolved
@gsk967 gsk967 requested a review from zarazan August 17, 2023 17:13
@gsk967 gsk967 enabled auto-merge August 18, 2023 15:24
@gsk967 gsk967 added this pull request to the merge queue Aug 19, 2023
Merged via the queue into main with commit b2fe120 Aug 19, 2023
26 checks passed
@gsk967 gsk967 deleted the sai/fix_duplicate_asset branch August 19, 2023 06:04
robert-zaremba pushed a commit that referenced this pull request Aug 30, 2023
* WIP: allow the duplicate symbols on leverage token registry

* fix the miss counter for duplicate symbol denoms

* +

* update the changelog and add comments about oracle votes on abci

* update the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants