Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about cwltool validation warning #30

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

alexiswl
Copy link
Member

@alexiswl alexiswl commented May 8, 2024

As discussed today

@alexiswl alexiswl added the enhancement New feature or request label May 8, 2024
@alexiswl alexiswl requested a review from skanwal May 8, 2024 11:00
@alexiswl alexiswl self-assigned this May 8, 2024
@alexiswl alexiswl linked an issue May 8, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 8, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/umccr/cwl-novice-tutorial/compare/md-outputs..md-outputs-PR-30

The following changes were observed in the rendered markdown documents:

 03-dependency_graphs.md | 54 +++++++++++++++++++++++++++++++++++++++++++++++++
 md5sum.txt              |  2 +-
 2 files changed, 55 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-08 11:02:54 +0000

github-actions bot pushed a commit that referenced this pull request May 8, 2024
Copy link
Member

@skanwal skanwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@alexiswl alexiswl merged commit 8518e02 into main May 9, 2024
4 checks passed
@alexiswl alexiswl deleted the enhancement/warning-note branch May 9, 2024 02:36
github-actions bot pushed a commit that referenced this pull request May 9, 2024
Auto-generated via {sandpaper}
Source  : 8518e02
Branch  : main
Author  : Alexis Lucattini <[email protected]>
Time    : 2024-05-09 02:36:52 +0000
Message : Merge pull request #30 from umccr/enhancement/warning-note

Add note about cwltool validation warning
github-actions bot pushed a commit that referenced this pull request May 9, 2024
Auto-generated via {sandpaper}
Source  : aed2d06
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-09 02:39:01 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 8518e02
Branch  : main
Author  : Alexis Lucattini <[email protected]>
Time    : 2024-05-09 02:36:52 +0000
Message : Merge pull request #30 from umccr/enhancement/warning-note

Add note about cwltool validation warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cwltool warning
2 participants