Remove merge status recheck (#18)

* remove merge status recheck * cast array of messages to send to slack
umbrellio · Jun 6, 2024 · 5f9660b · 5f9660b
1 parent 6b75ea2
commit 5f9660b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/api/GitLab.js b/api/GitLab.js
@@ -20,14 +20,13 @@ class GitLab {
 
   project = id => this.__get(this.__getUrl("projects", id))
 
-  requests = (project, { withMergeStatusRecheck }) => {
+  requests = project => {
     const query = {
       sort: "asc",
       per_page: 100,
       state: "opened",
       scope: "all",
       wip: "no",
-      with_merge_status_recheck: withMergeStatusRecheck,
     }
 
     const uri = this.__getUrl("projects", project, "merge_requests")

diff --git a/api/Messenger.js b/api/Messenger.js
@@ -23,9 +23,9 @@ class Messenger {
   }
 
   sendMany = messages => {
-    _.castArray(messages).forEach((message, idx) => {
-      _.delay(() => this.send(message), 100 * idx)
-    })
+    return _.castArray(messages).reduce((promise, message) => {
+      return promise.then(() => this.send(message))
+    }, Promise.resolve())
   }
 }
 

diff --git a/tasks/Unapproved.js b/tasks/Unapproved.js
@@ -175,12 +175,10 @@ class Unapproved extends BaseCommand {
   }
 
   __getExtendedRequests = projectId => {
-    const checkConflicts = this.__getConfigSetting("unapproved.checkConflicts", false)
-
     return this.gitlab
       .project(projectId)
       .then(project => this.gitlab
-        .requests(project.id, { withMergeStatusRecheck: checkConflicts })
+        .requests(project.id)
         .then(requests => {
           const promises = requests.map(request => this.__getExtendedRequest(project, request))
           return Promise.all(promises)