Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#621 Release page markup & style changes #643

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lynnewritescode
Copy link
Contributor

@lynnewritescode lynnewritescode commented Oct 17, 2020

Before:
before

After:
after

Alignment before:
alignment-before

Alignment after:
alignment-after

Copy link
Contributor

@abjerner abjerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @lynnewritescode - this looks so much better 👍

@lynnewritescode
Copy link
Contributor Author

Great work @lynnewritescode - this looks so much better 👍

Thank you @abjerner!

# Conflicts:
#	OurUmbraco.Site/Views/Release.cshtml
@nul800sebastiaan
Copy link
Member

Thanks @lynnewritescode ! This introduces a few problems that you could not have known about 🙈 The release page has changed in 8.7.0, so the layout is slightly different. I think you can reproduce by creating an 8.7.0 node in the test database (or rename 8.6.0 to 8.7.0).

With your changes that looks a bit like this:

image

8.6.0 and lower looks great!

The other thing that this seems to affect is the releases overview:

image

And the compare looks a bit off now as well:

image

I'd love it if you could have a look at this! Note that I did a merge and pushed some commits into your branch, you should be able to do a pull on your branch to get the latest version, let me know if you need help with that.

@lynnewritescode
Copy link
Contributor Author

@nul800sebastiaan Oh no! I can take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too long issue title places contributor image on a second line
3 participants