WIP: Issues should be added to Examine for better performance #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The RepositoryManagementService and Issue now relies on manual parsing the JSON, as this gives us some more control - As a result of above, Issue is now mostly just a wrapper for GitHubIssue from my GitHub package (means less logic for us to handle in this repo) - Comments and Events are now lazy loaded as we may not always need them - Added new PullRequest class, which is currently just an empty class inheriting from the Issue class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very much work in progress 😄
I only had a brief moment to work on this, so the first step is changing a bit in the way issues are loaded from disk. This is partially to utilize my GitHub package a bit more, as we then have to implement less logic for Our.