Skip to content

Commit

Permalink
Fail fast, add minimal reqs and different python versions
Browse files Browse the repository at this point in the history
  • Loading branch information
almet committed Nov 23, 2023
1 parent 9c559e3 commit 7c4b7cd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/test-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.11"] # ["3.8", "3.9", "3.10", "3.11", "3.12"]
dependencies: [normal] # [normal, minimal]
database: [postgresql] # maybe check different versions of postgres ?
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
dependencies: [normal, minimal]
database: [postgresql]

steps:
- uses: actions/checkout@v3
Expand All @@ -49,7 +49,7 @@ jobs:
make installjs

This comment has been minimized.

Copy link
@yohanboniface

yohanboniface Nov 23, 2023

Member

python -m pip install -e ".[dev,test]" => make develop ?

This comment has been minimized.

Copy link
@almet

almet Nov 23, 2023

Author Member

I've used the makefile targets everywhere instead. I was doing this because tox complaned against it, but I ditched it so we're good.

make install vendors

This comment has been minimized.

Copy link
@yohanboniface

yohanboniface Nov 23, 2023

Member

this install is useless ;)

This comment has been minimized.

Copy link
@almet

almet Nov 23, 2023

Author Member

I don't understan why? (In the makefile they are two different targets and do not depend on each other)

This comment has been minimized.

Copy link
@almet

almet Nov 23, 2023

Author Member

ah, just the "install", gotcha :-)

- name: run tests
run: pytest .
run: pytest -vx .
env:
DJANGO_SETTINGS_MODULE: 'umap.tests.settings'
UMAP_SETTINGS: 'umap/tests/settings.py'
Expand Down

0 comments on commit 7c4b7cd

Please sign in to comment.