Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump matrix-sdk dependency to 0.8. #386

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dstu
Copy link

@dstu dstu commented Jan 6, 2025

This accommodates recent protocol changes and addresses #378.

This accommodates recent protocol changes and addresses ulyssa#378.
@vkleen
Copy link

vkleen commented Jan 6, 2025

It looks like a flake.nix needs to be updated as well like in #214.

Copy link

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Rust SDK maintainer over here. Thanks for doing this PR, it's interesting for us to see how many breaking changes we've introduced, and this helped me realized a doc comment was wrong about compute_display_name(). I made a few suggestions below, but generally the code looks good to me.

src/notifications.rs Outdated Show resolved Hide resolved
src/worker.rs Outdated Show resolved Hide resolved
src/worker.rs Outdated Show resolved Hide resolved
src/worker.rs Outdated Show resolved Hide resolved
src/worker.rs Outdated Show resolved Hide resolved
@ulyssa
Copy link
Owner

ulyssa commented Jan 7, 2025

The changes here look good to me! I'm going to try this out locally a little bit first, but I think the only thing left that this needs is a run of cargo +nightly fmt to fix CI.

@dstu
Copy link
Author

dstu commented Jan 7, 2025

Hm, it looks like matrix-sdk 0.9 just got released (in the last 20 days). Happy to keep get this merged and then work on migrating to 0.9. But, if it's better to jump straight to 0.9, then I can transition to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants