Support enabling multiple notification sinks #344
Conversation
src/config.rs
Outdated
| #[serde(untagged)] | ||
| Multiple(Vec<Self>), |
There was a problem hiding this comment.
This technically allows [["bell", "bell"], "desktop"] and other silly settings, but for code simplicity that feels fine to me. The other approach would be to use something like bitflags but I'm not sure how complicated deserializing that would be.
There was a problem hiding this comment.
I think that making this look like a bitwise-or would be good so that folks can write via: "bell|desktop". There's an example of what that looks like here for VimModes which you could copy for making a NotifyViaSet(Vec<NotifyVia>) type.
There was a problem hiding this comment.
Finally got around to changing it to look like a bitwise-or, and added parser tests for it.
Nemo157
force-pushed
the
push-xmmwulpstkml
branch
from
d80a739 to
b0d7baf
Compare
|
This looks great! Thank you for adding tests for it, too! |
ulyssa
changed the title
Fixes #340, as I mention there I have a usecase for using both kinds of notifications at the same time.