Give option to not advertise a primary service #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_service
has an additional argumentadvertised
which isNone
by default.if
advertised is None
, then the behavior is unchanged compared to before.if
advertised
isTrue
orFalse
, its value is used to determine whether the service should be advertised.Since
advertised
has default valueNone
, this pull request is backwards compatible with all existing bluezero code.In addition, it gives developers the option to not advertise a primary service. This is useful because BLE has a maximum advertising size of 31 bytes, and a service UUID can use up to 16 bytes, which leaves little or no room for other data.