docs: adapting 'Using BAS with wdi5' section to wdi5 version 2 #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vobu
reviewed
Oct 18, 2023
docs/usage.md
Outdated
| The `Headless Testing Framework` extension installs the Firefox browser which allows you to use the wdi5 capabilities when working in SAP Business Application Studio. | ||
|
|
||
| **Important:** | ||
| Make sure you are using a Mozilla Firefox browser. Google Chrome is not supported. |
There was a problem hiding this comment.
probably better wording: "Make sure you are configuring Mozilla Firefox as the target browser" as there is not really a choice currently
docs/usage.md
Outdated
| To enable the extension: | ||
|
|
||
| 1. Add the `Headless Testing Framework` extension to your dev space. This will install a Firefox driver in the dev space. | ||
|
|
||
| 2. Verify that the Firefox driver has been installed correctly using the following commands on the Terminal: | ||
| 2. Make sure that the wdio libraries in the `Dependencies` are updated to at least version 8: |
There was a problem hiding this comment.
Suggested change
| 2. Make sure that the wdio libraries in the `Dependencies` are updated to at least version 8: | |
| 2. Make sure that the wdio libraries in the `devDependencies` are updated to at least version 8: |
docs/usage.md
Outdated
| ], | ||
| "ui5" | ||
| ] | ||
| services: ["geckodriver", "ui5"], |
There was a problem hiding this comment.
i would suggest leaving out any config for wdi5 < 2 as you're listing wdio^8 as a prerequisite above. And wdio^8 will not work with wdi5 < 2 anyway
vobu
reviewed
Oct 18, 2023
vobu
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.