Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIO switch to WW3 to avoid build errors #2512

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Nov 22, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR updates the WW3 submodule to address a build issue that arose in PR

This fixes #2502

Commit Message:

* UFSWM -  updates WW3 subcomponent
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 -  Updated to add PIO switch to avoid build error 
  * fire_behavior
  * stochastic_physics - 

Update WW3 to add PIO switch to avoid build error.

Priority:

  • Critical Bugfix: The workflow cannot update to the latest version of ufs-weather-model until the WW3 build issue is addressed.

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Note this was also tested in g-w with 1 test. G-W branch is here: https://github.com/JessicaMeixner-NOAA/global-workflow/tree/bug/addPIOswitch
And output of test is here: /work2/noaa/marine/jmeixner/hercules/piogw/test04 (it's still going, but it's far enough along to say that it worked). Standalone WW3 regression tests were also run. Details in the WW3 PR.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@jkbk2004 - Is there anything else I need to do on my end other than keep this PR up to date with the top of develop? In my opinion, this PR can be combined with whatever make sense to others. Just let me know if there are other things I can do from my end. Note I will be on leave Wed-Friday but will be back on Monday.

@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA We will schedule to bring this pr in early next week: Monday or Tuesday.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Thanks @jkbk2004 - Please let me know if there's anything I need to do from my end.

grantfirl added a commit to grantfirl/ufs-weather-model that referenced this pull request Dec 3, 2024
FernandoAndrade-NOAA pushed a commit that referenced this pull request Dec 6, 2024
…WW3 to avoid build errors #2512 (#2483)

* UFSWM - MYNN PBL, Smoke and subgrid cloud fraction.
  * FV3 - MYNN PBL, Smoke and subgrid cloud fraction.
    * ccpp-physics - MYNN PBL, Smoke and subgrid cloud fraction.
    * atmos_cubed_sphere - hail diagnostics, and average of smoke/dust.
  * WW3 -  Updated to add PIO switch to avoid build error
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 6, 2024

merged with #2483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WW3 cannot build pre-and-post processing jobs
2 participants