Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mom6 to its main repo. 20240824 commit (FMA) #2412

Merged
merged 16 commits into from
Sep 9, 2024
Merged

update mom6 to its main repo. 20240824 commit (FMA) #2412

merged 16 commits into from
Sep 9, 2024
+2,237 −2,129

Conversation

jiandewang
Copy link
Collaborator

@jiandewang jiandewang commented Aug 26, 2024 •
edited
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

MOM6 main repo. was updated on 20240824 which is GFDL's FMA PR (see detail at mom-ocean/MOM6#1634. This updating is aimed to eliminate future FMA related non-reproduciable issue on wcoss2. So a new BL is needed for wcoss2 but not for other platforms.

Commit Message:

  MOM6 - update MOM6 to its main repo. 20240824 updating (GFDL's FMA PR)

Priority:

Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines: new BL is needed for wcoss2

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@jiandewang
Copy link
Collaborator Author

add HERA full test log:
Regression-HERA.log.pdf

@jiandewang
Copy link
Collaborator Author

@jkbk2004 can you put this PR in commit queue ? Thanks

@jkbk2004
Copy link
Collaborator

@jkbk2004 can you put this PR in commit queue ? Thanks

@jiandewang Sure! I updated the table: possible commit date around 08/30 or 09/02.

@jiandewang
Copy link
Collaborator Author

@jkbk2004 can you put this PR in commit queue ? Thanks

@jiandewang Sure! I updated the table: possible commit date around 08/30 or 09/02.

sounds good. Thanks

@jiandewang
Copy link
Collaborator Author

@jkbk2004
https://github.com/ufs-community/ufs-weather-model/wiki/Commit-Queue
here you marked PR #2412 as no BL chnage. In fact this requires a new BL on wcoss2

@jkbk2004
Copy link
Collaborator

@jkbk2004 https://github.com/ufs-community/ufs-weather-model/wiki/Commit-Queue here you marked PR #2412 as no BL chnage. In fact this requires a new BL on wcoss2

@jiandewang Got it! I updated the table.

@FernandoAndrade-NOAA
Copy link
Collaborator

@jiandewang This PR is next for testing, please go ahead and sync/resolve conflicts.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Sep 4, 2024
@zach1221 zach1221 added jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Sep 5, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 6, 2024

Full RT ran ok on orion but it seems rt.sh has an issue to create log.: /work/noaa/epic/jongkim/UFS-RT/orion/rt-2412/tests/logs/log_orion. @zach1221 @FernandoAndrade-NOAA Please, skip Orion log.

@jkbk2004 jkbk2004 mentioned this pull request Sep 6, 2024
Closed
@zach1221
Copy link
Collaborator

zach1221 commented Sep 6, 2024

Looks like we'll need to skip Derecho as well due to issue #2429

@DeniseWorthen
Copy link
Collaborator

How about just fixing issue #2429 instead?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 6, 2024

Develop branch has same build issue on Derecho. We had no problem with previous PRs. @RatkoVasic-NOAA it points lib is corrupted. If no quick fix is available, we will skip Derecho to merge this PR.

@zach1221
Copy link
Collaborator

zach1221 commented Sep 6, 2024

Derecho looks like it's running now. Hopefully I'll have completed logs soon.

@zach1221
Copy link
Collaborator

zach1221 commented Sep 6, 2024

Testing is complete.

@jiandewang
Copy link
Collaborator Author

MOM6 merged with hash # 5e0c21f
UWM submodule reverted

@zach1221 zach1221 merged commit 6a4e09e into ufs-community:develop Sep 9, 2024
3 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/ufs-weather-model that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
fb22998 
…r-model into develop

* 'develop' of https://github.com/ufs-community/ufs-weather-model:
  update mom6 to its main repo. 20240824 commit (FMA) (ufs-community#2412)
  Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was ufs-community#2417) (ufs-community#2395)
  Combination for CCPP-physics ufs-community#213 and ufs-community#218 (H2O scheme refactor and C3/SAS/MYNN fix) (ufs-community#2408)
  Unify CDEPS gfs, cfsr, and gefs datm datamodes + Improve error checking in rt.sh (2388) + Add ability to read increment files on native cubed sphere grid (2304) (ufs-community#2389)
  sync with head of NOAA-EMC UPP develop (ufs-community#2326)
  Allow use of downscaled warmstart files for cpld_control_sfs test (ufs-community#2375)
  update to MOM6 main 20240729 commit (gfdl-to-main-2024-05-31) (ufs-community#2381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

Assignees
No one assigned
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update MOM6 to its main repo. 20240824 commit (FMA PR)
6 participants
@jiandewang @jkbk2004 @FernandoAndrade-NOAA @zach1221 @DeniseWorthen @BrianCurtis-NOAA