Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_packets_sub9.py #1100

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Update test_packets_sub9.py #1100

merged 4 commits into from
Nov 10, 2023

Conversation

MrinallU
Copy link
Contributor

Description

Added new tests for sub9 usb to can driver

Screenshot or Video

Related Issues

- Closes #1092

Testing

All new tests pass

About This PR

  • I have updated documentation related to this change so that future members are aware of the changes I've made.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MrinallU MrinallU requested a review from cbrxyz October 25, 2023 18:05
@uf-mil-bot
Copy link
Collaborator

uf-mil-bot commented Oct 25, 2023

Hola, your friendly InvestiGator bot here with another message!

Because this PR was closed/merged, I'm going to remove the docs preview for now.

Have a great day! Go gators! 🐊

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just look over the one comment and also run your code through pre-commit: https://uf-mil.github.io/docs/software/devtools.html#pre-commit!

@@ -6,9 +6,9 @@
from mil_usb_to_can.sub9 import Packet
from mil_usb_to_can.sub9.packet import SYNC_CHAR_1, SYNC_CHAR_2


# payload_format must follow format characters listed here: https://docs.python.org/3/library/struct.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need this comment. This is clear if you're using the library.

MrinallU and others added 2 commits October 26, 2023 05:55

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work!

@cbrxyz cbrxyz enabled auto-merge (squash) October 26, 2023 20:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@cbrxyz cbrxyz merged commit 0f3d837 into master Nov 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for sub9 submodule of mil_usb_to_can
3 participants