Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added respawn delay to connector nodes #1044

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

Haengele
Copy link
Contributor

@Haengele Haengele commented Apr 17, 2023

Description

I added a respawn delay to the nodes for the DVL, Depth Sensor, and IMU in the nav_box.launch launch file. This means when they encounter an error and close, they should wait 10 seconds before restarting.
Additionally, the drivers for the DVL, Depth Sensor, and IMU were modified in order to change the errors to ROS_ERROR_THROTTLE, so that the errors these files would spam will instead only appear once every 5 seconds.

Screenshot or Video

Related Issues

- Closes #1035

Testing

Run main sub8 launch file, and observe that the connection nodes no longer spam errors.

About This PR

  • I have updated documentation related to this change so that future members are aware of the changes I've made.

@uf-mil-bot
Copy link
Collaborator

uf-mil-bot commented Apr 17, 2023

Hola, your friendly InvestiGator bot here with another message!

Because this PR was closed/merged, I'm going to remove the docs preview for now.

Have a great day! Go gators! 🐊

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes so far look great, just waiting on the internal DVL attempt to write to be disabled (the red errors that are still frequently spamming)

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cbrxyz cbrxyz merged commit 824c481 into master Feb 28, 2024
@cbrxyz cbrxyz deleted the stop-connector-error-spam branch February 28, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent the connector nodes from spamming errors when not having a connection
3 participants