fix: don't rend the HTML tags

uetchy · Oct 4, 2022 · e242a44 · e242a44
1 parent fac1ccc
commit e242a44
Showing 1 changed file with 17 additions and 5 deletions.
diff --git a/PolyglotSafariExtension/Sources/content.ts b/PolyglotSafariExtension/Sources/content.ts
@@ -79,16 +79,28 @@ function translationErrorHandler(message: UpstreamError) {
   showError(message.error);
 }
 
+function convertHTMLToDisplayText(htmlString: string): string {
+  let encodedString = htmlString.replace(/&/g, "&amp;");
+  encodedString = encodedString.replace(/</g, "&lt;");
+  encodedString = encodedString.replace(/>/g, "&gt;");
+  encodedString = encodedString.replace(/"/g, "&quot;");
+
+  return convertNewlineToHTML(encodedString);
+}
+
+function convertNewlineToHTML(text: string): string {
+  return text.replace(/\n/g, "<br/>");
+}
+
 function translationHandler(message: ReceivedTranslation): void {
   if (message.id !== window.location.href) return;
 
   const args = {
     sourceLanguage: message.sourceLanguage || null,
-    translation: message.translation.replace(/\n/g, "<br/>"),
-    transliteration: message.transliteration.replace(/\n/g, "<br/>"),
-    sourceTransliteration: message.sourceTransliteration.replace(
-      /\n/g,
-      "<br/>"
+    translation: convertHTMLToDisplayText(message.translation),
+    transliteration: convertHTMLToDisplayText(message.transliteration),
+    sourceTransliteration: convertHTMLToDisplayText(
+      message.sourceTransliteration
     ),
     synonyms: message.synonyms
       ? message.synonyms.map((synonym) => ({