Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

Port the bubble menu #203

Closed
wants to merge 9 commits into from
Closed

Port the bubble menu #203

wants to merge 9 commits into from

Conversation

hanspagel
Copy link
Contributor

PR from @nutheory

One thing I’ve seen already: The custom cordsAtPos has been removed, and needs to be added. See ueberdosis/tiptap#215

@nutheory
Copy link
Collaborator

hey thats fixed now in my repo and i added the float menu for ya.

@jnarowski
Copy link
Collaborator

Wanted to know what the status of this was? Would love to use the Bubble Menu!

@nutheory
Copy link
Collaborator

@hanspagel as i'm implementing this for alpinejs in my own project i'm realizing the need to set this.updatedAt on every event to get it to work properly. My question is, is there any good reason to set updatedAt on the editor "automagically" to make agnostic development a little more seamless?

@nutheory
Copy link
Collaborator

or maybe make it a config setting on the editor itself?

@hanspagel
Copy link
Contributor Author

hanspagel commented Mar 30, 2021

Thanks for your work on this! We’ve taken what you’ve build, added a few other improvements and plan to release a first version soon.

BTW We’ll provide a Vue, React and Vanilla JS version. The JS version will make it easy to integrate with Alpine.

@hanspagel hanspagel closed this Mar 30, 2021
@philippkuehn philippkuehn deleted the feature/bubble-menu branch April 1, 2021 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants