Pass provider options and query params to authorize_url #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahryarjb
suggested changes
Mar 30, 2022
| @@ -28,6 +28,7 @@ defmodule UeberauthTwitter.Mixfile do | |||
| {:httpoison, "~> 1.0"}, | |||
| {:oauther, "~> 1.1"}, | |||
| {:ueberauth, "~> 0.6"}, | |||
| {:hackney, "~> 1.16", override: true}, | |||
There was a problem hiding this comment.
I think hex does not let you publish a package when you use override: true in deps
| @@ -23,19 +23,22 @@ _Note_: Sessions are required for this strategy. | |||
| ```elixir | |||
| config :ueberauth, Ueberauth, | |||
| providers: [ | |||
| twitter: {Ueberauth.Strategy.Twitter, []} | |||
| twitter: {Ueberauth.Strategy.Twitter, [authorize_url: "/oauth/authenticate"]} | |||
There was a problem hiding this comment.
Does it fix ** (Ueberauth.Strategy.Twitter.OAuth.ApiError) Could not authenticate you. (Code 32) ?
|
Are there any plans on merging this? Going through the "I authorize the app to do so" flow every login is a little cumbersome. |
|
@benvp not sure if @ntilwalli is still interested in continuing the work. I can't take the workload at the very moment, so please take the lead and I will assist you as much as I can with it |
|
Thanks for the reply. Will have a look and see how to bring this forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrate changes from #32 and #34, fixes tests as well as passes provider options to
authorize_url!. This allows the request url to be configured since Twitter offers both an/oauth/authorizeand/oauth/authenticateendpoint. The former endpoint requires the user goes through the app permission workflow each time, latter endpoint allows users to authenticate once and not have to authorize on subsequent login attemps until they revoke access. See StackOverflow discussion here.