Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes and refactor #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

darrenklein
Copy link

Thank you so much for creating this very helpful example repo! While using it to help me in my own project development, I spotted a few small fixes that I think would benefit this project.

  • replaces use Guardian.Token.Jwt.SecretFetcher with @behaviour Guardian.Token.Jwt.SecretFetcher, since the example uses a custom implementation of fetch_signing_secret and fetch_verifying_secret rather than the default implementations use would provide.
  • updates the documentation to match that, including a fix for a reference to :debug_guardian
  • other small refactors and cleanup

Again, many thanks - your example helped me out a lot, I hope these contributions are beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant