Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the field attribute on PrimeNG AutoComplete. Fix #1100. #1105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for the field attribute on PrimeNG AutoComplete. Fix #1100. #1105

wants to merge 1 commit into from

Conversation

vstiebe
Copy link

@vstiebe vstiebe commented Aug 24, 2020

No description provided.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (development@bdc791b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1105   +/-   ##
==============================================
  Coverage               ?   82.09%           
==============================================
  Files                  ?      170           
  Lines                  ?     2072           
  Branches               ?      247           
==============================================
  Hits                   ?     1701           
  Misses                 ?      276           
  Partials               ?       95           
Impacted Files Coverage Δ
...lib/model/colorpicker/dynamic-colorpicker.model.ts 85.71% <0.00%> (ø)
...icker/dynamic-ng-bootstrap-datepicker.component.ts 100.00% <0.00%> (ø)
...s/core/src/lib/model/dynamic-date-control.model.ts 55.55% <0.00%> (ø)
...b/form-array/dynamic-kendo-form-array.component.ts 11.11% <0.00%> (ø)
...c/lib/rating/dynamic-bootstrap-rating.component.ts 100.00% <0.00%> (ø)
...icker/dynamic-ng-bootstrap-timepicker.component.ts 100.00% <0.00%> (ø)
projects/ng-dynamic-forms/ui-ionic/src/test.ts 100.00% <0.00%> (ø)
...rc/lib/service/dynamic-form-validation-matchers.ts 80.00% <0.00%> (ø)
...lib/model/checkbox/dynamic-checkbox-group.model.ts 100.00% <0.00%> (ø)
...c/lib/checkbox/dynamic-basic-checkbox.component.ts 100.00% <0.00%> (ø)
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc791b...5b68560. Read the comment docs.

@matheo
Copy link

matheo commented Apr 18, 2021

Hi @vstiebe
Do you mind to share your experience with dynamic forms
in the discussions of a new library to implement advanced features?
https://dev.to/myndpm/a-new-approach-to-have-dynamic-forms-in-angular-5d11
Thanks in advance!

@vstiebe
Copy link
Author

vstiebe commented Apr 19, 2021

Hi @matheo.

I have adopted ngx-formly for all features and simplicity to add new controls without the need for forking or waiting for merging on the original library.

I'll try to take a look on your approach when I'm able to find some free time.

Hi @vstiebe
Do you mind to share your experience with dynamic forms
in the discussions of a new library to implement advanced features?
https://dev.to/myndpm/a-new-approach-to-have-dynamic-forms-in-angular-5d11

@matheo
Copy link

matheo commented Apr 19, 2021

Nice to hear @vstiebe
Lookiing forward for your impression!
I've tried to make the config more organized Stackblitz demo
and I'm collecting experiences and feedback to improve it even more 😉

Feel free to say Hi at the discussions :)

@udos86 udos86 changed the base branch from development to master December 3, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants