chore: updated handling of markdown headers #3896
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const type = options.editor.getType({ key: headingType }); | ||
|
|
||
| if (!type) { | ||
| console.warn(`Heading type ${headingType} not registered in editor`); |
There was a problem hiding this comment.
I'm not sure we want to warn here. We could default to the latest heading type supported (e.g. h3)
There was a problem hiding this comment.
the issue with this is that h3 will be confusing. Its difficult to understand the issue otherwise. I will keep it on p unless you insist.
packages/markdown/src/lib/remark-slate/remarkDefaultElementRules.ts
Outdated
Show resolved
Hide resolved
|
Looks good, just need to fix the CI |
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changesetThis PR updates the handling of headers when deserializing markdown. Tests have been updated as well.