refactor to work with Gulp 4 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://www.sitepoint.com/automate-css-tasks-gulp/ https://gulpjs.com/docs/en/getting-started/quick-start https://gulpjs.com/docs/en/getting-started/creating-tasks https://gulpjs.com/docs/en/getting-started/async-completion consulted 2019-06-17 as well as the Udacity course materials https://classroom.udacity.com/nanodegrees/nd001/parts/20f5a632-38e6-48e7-88c8-e14c21590bb9/modules/de442af7-4ae2-48d7-a613-cf132eeaf60c/lessons/5831481034/concepts/55096392250923
|
Please feel free (a) to ignore this PR entirely if it's not appropriate to the course content, and (b) to delete my INTRO comments if you want to use any of this. Thanks for reviewing this PR. |
|
Please note: although I modified gulpfile.js for Lesson 4, I believe that this approach should also address this issue 6, see, e.g., the 1/29/19 comment. |
TODO: Terminal version of tests() generates non-fatal errors, which appear
to arise from Jasmine configuration
|
I've gone ahead and made similar changes to Lesson 4 - Part 2 - Lesson 5, also noting (a) corresponding changes to package.json in that lesson and (b) potential future todo. |
Based on https://www.npmjs.com/package/@babel/core https://babeljs.io/docs/en/babel-register consulted 2019-06-20 https://gulpjs.com/docs/en/getting-started/creating-tasks#exporting jasmine/jasmine-npm#145 jasmine/jasmine-npm#145 (comment) https://jasmine.github.io/setup/nodejs.html https://stackoverflow.com/questions/51069142/whats-the-difference-between-uglify-js-and-uglify-es consulted 2019-06-18 and also https://www.sitepoint.com/automate-css-tasks-gulp/ https://gulpjs.com/docs/en/getting-started/quick-start https://gulpjs.com/docs/en/getting-started/creating-tasks https://gulpjs.com/docs/en/getting-started/async-completion consulted 2019-06-17 as well as the Udacity course materials https://classroom.udacity.com/nanodegrees/nd001/parts/20f5a632-38e6-48e7-88c8-e14c21590bb9/modules/de442af7-4ae2-48d7-a613-cf132eeaf60c/lessons/5831481034/concepts/55096392250923 https://classroom.udacity.com/nanodegrees/nd001/parts/20f5a632-38e6-48e7-88c8-e14c21590bb9/modules/de442af7-4ae2-48d7-a613-cf132eeaf60c/lessons/5876358842/concepts/53738292320923 NOTE: Corresponding package.json shown in comments at bottom
|
And I've made corresponding changes to Lesson 4 - Part 2 - Lesson 6, Awesome Optimizations, again noting (a) corresponding changes to package.json in that lesson and (b) potential future todos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://www.sitepoint.com/automate-css-tasks-gulp/
https://gulpjs.com/docs/en/getting-started/quick-start
https://gulpjs.com/docs/en/getting-started/creating-tasks
https://gulpjs.com/docs/en/getting-started/async-completion
consulted 2019-06-17 as well as the Udacity course materials
https://classroom.udacity.com/nanodegrees/nd001/parts/20f5a632-38e6-48e7-88c8-e14c21590bb9/modules/de442af7-4ae2-48d7-a613-cf132eeaf60c/lessons/5831481034/concepts/55096392250923