Loading without internet #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x/Bruin-Bite-iOS into Loading-Without-Internet
HirdayGupta
requested changes
Nov 27, 2018
| @@ -9,10 +9,86 @@ | |||
| import UIKit | |||
| import Moya | |||
| import SnapKit | |||
| import Reachability | |||
|
|
|||
| class NetworkManager: NSObject { | |||
There was a problem hiding this comment.
Move this class to a new file called NetworkManager.swift under the Helpers folder.
|
|
||
| class MenuVC: UIViewController, UICollectionViewDelegate, UICollectionViewDataSource, UICollectionViewDelegateFlowLayout{ | ||
|
|
||
| let provider = MoyaProvider<API_methods>() | ||
| let reachability = Reachability()! |
There was a problem hiding this comment.
You don't need this. Delete this.
| @@ -321,7 +411,5 @@ class MenuVC: UIViewController, UICollectionViewDelegate, UICollectionViewDataSo | |||
| if (segue.identifier == "segueToItemDetailVC") { | |||
| let vc = segue.destination as! ItemDetailViewController | |||
| vc.menuItem = self.menuItem | |||
| } | |||
| } | |||
| } } | |||
There was a problem hiding this comment.
unrelated change. please revert to older indentation.
| @@ -0,0 +1,415 @@ | |||
| // | |||
There was a problem hiding this comment.
this file seems to have been added in by accident, please delete it. NOTE: I am asking you to delete Bruin Bite.xcodeproj/MenuVC.swift NOT Bruin Bite/View Controllers/MenuVC.swift
|
made requested changes in #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
Added changes necessary to see if loading label without internet would work, I think it works well but not sure I uploaded it properly