Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch dev.Dockerfile to use node14 alpine, changes node-sass version to use node 14 binary #93

Closed
wants to merge 2 commits into from

Conversation

mattxwang
Copy link
Member

No description provided.

@mattxwang mattxwang marked this pull request as draft August 7, 2021 23:37
@reginawang3495
Copy link

Anything I can help with here? Is this something that you were still thinking of getting out?

@mattxwang
Copy link
Member Author

If we figure out #94 and #92, this is probably unneeded; this was just to see if we could resolve an issue Dylon was having running the membership portal.

(the gist of the issue is that node-sass is a native module, and the dockerfile's build process installs node_modules first, then enters the container; so, the native modules aren't built properly for the docker host OS, and things fail.)

@mattxwang mattxwang closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants