Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question ID Management needs an overhaul #1188

Closed
clpetersonucf opened this issue Jan 2, 2019 · 2 comments
Closed

Question ID Management needs an overhaul #1188

clpetersonucf opened this issue Jan 2, 2019 · 2 comments
Labels

Comments

@clpetersonucf
Copy link
Member

We're not strictly enforcing uniqueness of question IDs the way we probably should: for instance, importing questions doesn't scrub the existing question ID, and importing the same question multiple times is an easy way to cause collisions. We need to better strip/regenerate question and answer IDs in a number of places:

  • JS: in engine/creatorcore, prior to being passed to the creator during question import
  • PHP: when storing into question bank

We'll have to manage handling both existing question IDs and creation/handling of new question IDs.

Lastly, we should switch to using uuids in find_questions on the PHP side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants