Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imported questions should strip all question/answer IDs. #37

Open
FrenjaminBanklin opened this issue Jan 2, 2019 · 0 comments
Open

Imported questions should strip all question/answer IDs. #37

FrenjaminBanklin opened this issue Jan 2, 2019 · 0 comments
Assignees
@FrenjaminBanklin

Comments

@FrenjaminBanklin
Copy link
Contributor

Refer to ucfopen/Materia#1188.

Question and answer IDs - though especially question ids - need to be unset on any imported questions to prevent the possibility of collisions within the same widget.

Example: Create a widget, import a question, then import the same question again. Now two copies of the same question exist in the widget, both with the same ID. At the very least this causes issues in (most) widget score modules.

Setting IDs to the default/null values will allow the backend to correctly set them uniquely and prevent collisions.
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Jan 2, 2019
Closed
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia-Server-Client-Assets that referenced this issue Jan 4, 2019
@FrenjaminBanklin
ucfopen#37 Imported questions and all of their answers now have the '…
4b138df 
…id' properties set to null, allowing the backend to set them freshly to prevent collisions.
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Jan 4, 2019
Merged
@clpetersonucf clpetersonucf mentioned this issue Jan 4, 2019
Merged
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia-Server-Client-Assets that referenced this issue Feb 13, 2019
@FrenjaminBanklin
ucfopen#37 Added quick safety check to make sure an imported question…
e53b248 
… has answers before trying to strip them of their ids.
@FrenjaminBanklin FrenjaminBanklin self-assigned this Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrenjaminBanklin FrenjaminBanklin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FrenjaminBanklin