Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/2.2.0 #96

Merged
merged 33 commits into from
Jul 9, 2020
Merged

dev/2.2.0 #96

merged 33 commits into from
Jul 9, 2020

Conversation

clpetersonucf
Copy link
Member

@clpetersonucf clpetersonucf commented Oct 28, 2019


hub pr list --base dev/2.2.0 --state closed --format "- [#%I](%U) - %t%n

  • #102 - Bump angular from 1.6.9 to 1.8.0
  • #101 - Widget Copy modal & Settings updates to better clarify permissions
  • #100 - Bump handlebars from 4.1.2 to 4.5.3
  • #99 - Add a button to disable Beard Mode on the profile settings page.
  • #95 - Materia.Engine does not check if received POST messages are valid #78 Add data type check for scorecore
  • #90 - #1066 Add inline info about previewing widgets and student view styling
  • #87 - #1259 lti picker refresh fix
  • #84 - Bump mixin-deep from 1.3.1 to 1.3.2

dependabot bot and others added 30 commits September 19, 2019 19:23
…yling

#1066 Add inline info about previewing widgets and student view styling
Add a button to disable Beard Mode on the profile settings page.
* new input description background on copy dialig reused in settings
* copy heading updated to use settings heading styles
* text made consistent across the widget share/settings/copy dialogs
* some minor style cleanup on things I touched
* update to mywidgets controller so the slider will update when chaning modes, it still needs a single function to set modes and change the mode ui to a radio button.
…copy

Widget Copy modal & Settings updates to better clarify permissions
…p-1.3.2

Bump mixin-deep from 1.3.1 to 1.3.2
…rs-4.5.3

Bump handlebars from 4.1.2 to 4.5.3
* deps updated to newest versions
* browserlist updated so polyfills and css prefixing use it
* webpack upgraded and simplified to use more common approach
* some search methods renamed to avoid polyfill incorrect detection
* console log output removed from tests
* comments on multiword filter to make it easier to understand
* focused webpack log output
* output js files grew in size due to polyfills now using automatic detections
* husky precommit now checks coverage
* batched controllers together so they're easier to find (ex: my-widgets-*)
* made controller names consistent - all UpperCamel (need to do all other modules)
My widgets page will show admin users greyed out copy
and delete buttons, however they still function.  The
problem is the client doesn't seem to understand su
roles, and all the logic does not include that as
and option.

This adds a more nuanced permission set on the selected
widget under $scope.slected.can with a key for each of
the permission types. Where possible, those have been
used, but theres some strangeness going on thats
difficult to follow/tanslate to can permissions.
I left those in place.

fixes #1296
Copy link
Member

@iturgeon iturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got a huge jump forward in build tooling and quality. Looking forward to the next steps :)

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't dive super deep, but checked all the bullet points and found nothing amiss.

Looks okay to me.

@clpetersonucf clpetersonucf merged commit 7b7abfb into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants