Added support for successive <> operations overriding each other. #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented and tested out both varieties of overriding bulk connects, letting
:=
override<>
and letting<>
override<>
, and I think a good case can be made for the latter.If
:=
/procAssign
were special-cased to override<>
/assign
only when no when condition exists, this special overriding assignment would necessarily not be able to be overridden again by a conditional:=
, making its meaning more similar toassign
thanprocAssign
.The second way has the tradeoff of requiring multiple calls to
assign
to succeed, but allowing overriding essentially implies that this is okay. It enforces a few rules:<>
can override<>
at any part of the hierarchy<>
cannot be conditional:=
cannot override<>
Rule 2 should be enforced even with the existing Chisel semantics, but this case currently produces incorrect results silently. This change also adds a check for this.