Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade bcrypt<4.0.0 for FireSim on AWS EC2 Centos7 + Install ninja by default for building CIRCT #2087

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Oct 16, 2024

Similar to firesim/firesim#1805. Also, adds ninja in case users need to build CIRCT from source.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See ci:* for full list of labels:

  • ci:fpga-deploy - Run FPGA-based E2E testing
  • ci:local-fpga-buildbitstream-deploy - Build local FPGA bitstreams for platforms that are released
  • ci:disable - Disable CI

@abejgonzalez abejgonzalez reopened this Oct 16, 2024
@abejgonzalez abejgonzalez changed the title Downgrade bcrypt<4.0.0 for FireSim on AWS EC2 Centos7 Downgrade bcrypt<4.0.0 for FireSim on AWS EC2 Centos7 + Install ninja by default for building CIRCT Oct 17, 2024
@abejgonzalez
Copy link
Contributor Author

Pending someone looking at the Ara build failures.

@abejgonzalez abejgonzalez merged commit b1e1e25 into main Oct 25, 2024
129 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants