Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent overflow of int values #89

Merged
merged 10 commits into from
Dec 2, 2024
Merged

fix: prevent overflow of int values #89

merged 10 commits into from
Dec 2, 2024

Conversation

fabiobozzo
Copy link
Collaborator

@fabiobozzo fabiobozzo commented Nov 29, 2024 •
edited
Loading

This PR adds JavaScript-safe integer bounds checking (±2^53-1) across the policy package. This ensures all integer operations remain within JavaScript's safe integer bounds, preventing potential overflow issues while maintaining UCAN spec compliance.

Changes

  • Added shared integer limits constants in pkg/internal/limits
  • Added bounds checking for integer comparisons in policy matching
  • Added validation for slice/index parsing in selectors
  • Added overflow protection for integer-to-IPLD conversion
  • Added comprehensive overflow test cases

@fabiobozzo fabiobozzo linked an issue Nov 29, 2024 that may be closed by this pull request
Prevent overflow of int values #77
Closed
MichaelMure
MichaelMure reviewed Dec 2, 2024
View reviewed changes
pkg/policy/match.go Outdated Show resolved Hide resolved
@MichaelMure MichaelMure merged commit 78d37d9 into main Dec 2, 2024
6 checks passed
@MichaelMure MichaelMure deleted the fix/prevent-int-overflow branch December 2, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMure MichaelMure MichaelMure approved these changes

@smoyer64 smoyer64 Awaiting requested review from smoyer64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent overflow of int values
2 participants
@fabiobozzo @MichaelMure