Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delegation: tune the validation step #25

Merged
merged 1 commit into from
Sep 19, 2024
Merged

delegation: tune the validation step #25

merged 1 commit into from
Sep 19, 2024

Conversation

MichaelMure
Copy link
Collaborator

  • avoid a double parsing when the flow already parsed (command, policy)
  • don't require a did:key, as other types are legal (but might require a resolver, TODO)
  • make the command a struct instead of a pointer: we don't need to avoid copy, and the pointer can be interpreted as nil
  • make the nonce parameter optional, but generate one if none is given

@MichaelMure
delegation: tune the validation step
684c21c 
- avoid a double parsing when the flow already parsed (command, policy)
- don't require a did:key, as other types are legal (but might require a resolver, TODO)
- make the command a struct instead of a pointer: we don't need to avoid copy, and the pointer can be interpreted as nil
- make the nonce parameter optional, but generate one if none is given
@MichaelMure MichaelMure changed the base branch from meta-delegation to v1 September 19, 2024 10:28
@MichaelMure MichaelMure merged commit 1301688 into v1 Sep 19, 2024
6 checks passed
@MichaelMure MichaelMure deleted the tune-validation branch September 19, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoyer64 smoyer64 smoyer64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelMure @smoyer64