Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add debug #94

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feat/add debug #94

wants to merge 4 commits into from

Conversation

jawadqur
Copy link
Contributor

@jawadqur jawadqur commented Jan 3, 2025

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

  • Since we are running flask behind a reverse proxy now (compared to before it was running in uwsgi) we have to add this to our code for the k8s based auth.

Improvements

Dependency updates

Deployment changes

Copy link

github-actions bot commented Jan 3, 2025

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

Copy link

github-actions bot commented Jan 3, 2025

Pull Request Test Coverage Report for Build 12601974906

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 85.685%

Files with Coverage Reduction New Missed Lines %
auth_plugins/k8s.py 9 58.62%
api.py 12 86.46%
Totals Coverage Status
Change from base Build 11898227420: -0.4%
Covered Lines: 425
Relevant Lines: 496

💛 - Coveralls

Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, should we change the logs to "debug" instead of "info"?

@jawadqur
Copy link
Contributor Author

jawadqur commented Jan 3, 2025

looks good, should we change the logs to "debug" instead of "info"?

yes, that makes more sense. Updated

Copy link

github-actions bot commented Jan 3, 2025

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_discoverypage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants