HP-1699 add user agent header #92
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 11039235829Details
💛 - Coveralls |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
wts/blueprints/oauth2.py
Outdated
| client.session.revoke_token(url, token) | ||
| app_version = flask.current_app.config.get("APP_VERSION", "0.0.0") | ||
| client.session.revoke_token( | ||
| url, token, headers={"User-Agent": f"Gen3WTS / {app_version}"} |
There was a problem hiding this comment.
| url, token, headers={"User-Agent": f"Gen3WTS / {app_version}"} | |
| url, token, headers={"User-Agent": f"Gen3WTS/{app_version}"} |
There was a problem hiding this comment.
Shoot, that isn't working for me. I'm getting an "Invalid username" message from https://idp.stage.qdr.org/ when I try to log in.
Can you verify if you are able to log in or not? The change is deployed in QA-HEAL.
I had tried removing the spaces in this earlier commit. I wasn't able to log in so I had reverted the change in the next commit.
There was a problem hiding this comment.
Just tried in QA, I could refresh my QDR creds after logging in via their staging env
Have you regierstered an account at https://stage.qdr.org/ ?
There was a problem hiding this comment.
Yes, it is now working for me! I'm able to log in to stage after being redirected from the qa-heal authorize_url endpoint. I'm not sure why it wasn't working earlier.
I will update the unit tests to remove the spaces in the expected header value.
wts/resources/oauth2.py
Outdated
| app_version = flask.current_app.config.get("APP_VERSION", "0.0.0") | ||
| tokens = client.fetch_token( | ||
| token_url, | ||
| headers={"User-Agent": f"Gen3WTS / {app_version}"}, |
There was a problem hiding this comment.
| headers={"User-Agent": f"Gen3WTS / {app_version}"}, | |
| headers={"User-Agent": f"Gen3WTS/{app_version}"}, |
Please find the detailed integration test report here Please find the ci env pod logs here |
JIRA ticket: HP-1699
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes