Fix: base copy permission on read permission #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Prokhorenkov <[email protected]> ...at 6a6e63c
…s for users TODO: This should be made configurable in the future...
…te access to a global shared artifact reader role that would be given to all users. Next steps are to 1) make this configurable, 2) allow users to configure the global author role if they want only some users to be able to grant global read access, and 3) set up global read role for all users as a default assigned system role Other commit messages squashed in here: - first working configuration of sharing using an authoring role - some fixes to global sharing after testing; moved the shared reader role to a new roleid. - started to implement the ability to hide the share-global buttons but then decided not to - changed the 'shared artifact reader' role checked by Atlas to be the 'public' role since this would remove the need to change WebAPI to add a new system role that pretty much duplicates 'public' - added the configurable ability to restrict generation of a given cohort to only persons who have been granted permission to change the same cohort.
…bal sharing ...and introduce some other fixes: - fix: correct styling for sharing buttons on access modal ui - fix: cleanup/remove unnecessary parts - fix: adjust permission name to "artifact:global:share:put" to better reflect its real purpose - fix: better name for isPermittedGlobalShareArtifact (previous name isPermittedGlobalShareCohort did not reflect the fact that it is about all kind of artifacts) - fix: move isOwner() check and make sure it is only applied when !config.limitedPermissionManagement - fix: move isOwner() check for conceptset-manager
based on this discussion OHDSI#2929 (comment)
...i.e. read permission should be sufficient to let the user copy the cohortdefinition
pieterlukasse
changed the title
pieterlukasse
force-pushed
the
2.15.0-DEV
branch
from
e5bb125 to
72b9b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...i.e. read permission should be sufficient to let the user copy the cohortdefinition
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes