Skip to content

Commit

Permalink
fix: disable not-so-useful parts of home,concept-set,cohort-definitio…
Browse files Browse the repository at this point in the history
…n pages

...simplifying them and making them more 508 compliant
  • Loading branch information
pieterlukasse committed Jan 2, 2025
1 parent f7c6d12 commit 542ccf4
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
6 changes: 6 additions & 0 deletions js/pages/cohort-definitions/cohort-definition-manager.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,17 @@
data-bind="title: ko.i18n('cohortDefinitions.cohortDefinitionManager.closeCohortTitle', 'Close cohort definition'), click: close, css: { disabled: isProcessing() }"><i
class="fa fa-times"></i></button>
<!-- ko if: currentCohortDefinition().id() != null && currentCohortDefinition().id() != 0 -->
<!-- Hide this not-so-useful part and make the page more 508 compliant:
<button class="btn btn-primary"
data-bind="title: ko.i18n('common.tags', 'Tags'), visible: canEdit() && !previewVersion(), click: () => isTagsModalShown(!isTagsModalShown()), css: { disabled: isProcessing() }"><i class="fa fa-tags"></i></button>
-->
<button class="btn btn-primary"
data-bind="visible: !previewVersion(), title: ko.i18n('cohortDefinitions.cohortDefinitionManager.createCopyCohortTitle', 'Create a copy of this cohort definition'), click: copy, enable: canCopy() && !isProcessing()"><i
class="fa fa-copy"></i></button>
<!-- Hide this not-so-useful part and make the page more 508 compliant:
<button class="btn btn-primary"
data-bind="visible: !previewVersion(), title: ko.i18n('cohortDefinitions.cohortDefinitionManager.getLinkCohortTitle', 'Get a link to this cohort definition'), enable: !dirtyFlag().isDirty() && !isProcessing(), click: function () { $component.cohortLinkModalOpened(true) }"><i class="fa fa-link"></i></button>
-->

<!-- ko if: (enablePermissionManagement() === true && userCanShare() === true) -->
<button class="btn btn-primary"
Expand Down Expand Up @@ -132,10 +136,12 @@
<a role="tab" data-bind="text: ko.i18n('cohortDefinitions.cohortDefinitionManager.panels.json', 'JSON')"></a>
</li>

<!-- Hide this not-so-useful part and make the page more 508 compliant:
<li role="presentation"
data-bind="css: { active: $component.exportTabMode() == 'sql' }, click: function() { $component.exportTabMode('sql');}">
<a role="tab" data-bind="text: ko.i18n('cohortDefinitions.cohortDefinitionManager.panels.sql', 'SQL')"></a>
</li>
-->
</ul>

<div class="tab-content">
Expand Down
12 changes: 7 additions & 5 deletions js/pages/concept-sets/conceptset-browser.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@
title: ko.i18n('cs.browser.tabs.list', 'List'),
componentName: 'conceptsets-list',
componentParams: componentParams,
},
{
title: ko.i18n('cs.browser.tabs.export', 'Export'),
componentName: 'conceptsets-export',
componentParams: componentParams,
}
]"></tabs>
<!-- Hide this not-so-useful part and make the page more 508 compliant:
{
title: ko.i18n('cs.browser.tabs.export', 'Export'),
componentName: 'conceptsets-export',
componentParams: componentParams,
}
-->
</div>

<access-denied params="isAuthenticated: isAuthenticated, isPermitted: hasAccess"></access-denied>
3 changes: 2 additions & 1 deletion js/pages/home/home.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<br/>
<a data-bind="attr: { href: webapiReleaseUrl }" target="_new">WebAPI Version <span data-bind="text: webapiVersion"></span> Release Notes</a>
</div>

<!-- Hide this not-so-useful part and make the page more 508 compliant:
<div data-bind="hidden: loading">
<div class="paddedWrapper" data-bind="html: ko.i18nformat('home.releaseNotes.issues', 'This latest release contains <b><%=issues%></b> feature enhancements and issue resolutions:', {issues: github_status().length})">
<br/>
Expand All @@ -42,6 +42,7 @@
</div>
</div>
</div>
-->
</div>
<loading data-bind="visible: loading" params="status: ko.i18n('home.releaseNotes.loadingReleaseInfo', 'Loading release info')"></loading>
</div>

0 comments on commit 542ccf4

Please sign in to comment.