refactor: updating protos to use common defs

proto/ratings_features_app.proto

@@ -2,6 +2,8 @@ syntax = "proto3";
 
 package ratings.features.app;
 
+import "ratings_features_common.proto";
+
 service App {
   rpc GetRating (GetRatingRequest) returns (GetRatingResponse) {}
 }
@@ -11,20 +13,5 @@ message GetRatingRequest {
 }
 
 message GetRatingResponse {
-  Rating rating = 1;
-}
-
-message Rating {
-  string snap_id = 1;
-  uint64 total_votes = 2;
-  RatingsBand ratings_band = 3;
-}
-
-enum RatingsBand {
-  VERY_GOOD = 0;
-  GOOD = 1;
-  NEUTRAL = 2;
-  POOR = 3;
-  VERY_POOR = 4;
-  INSUFFICIENT_VOTES = 5;
+  ratings.features.common.Rating rating = 1;
 }

proto/ratings_features_chart.proto

@@ -2,6 +2,8 @@ syntax = "proto3";
 
 package ratings.features.chart;
 
+import "ratings_features_common.proto";
+
 service Chart {
   rpc GetChart (GetChartRequest) returns (GetChartResponse) {}
 }
@@ -16,24 +18,12 @@ message GetChartResponse {
 }
 
 message ChartData {
-  string app = 1;
-  uint64 total_up_votes = 2;
-  uint64 total_down_votes = 3;
-  float rating = 4;
-  RatingsBand rating_band = 5;
+  float raw_rating = 1;
+  ratings.features.common.Rating rating = 2;
 }
 
 enum Timeframe {
   TIMEFRAME_UNSPECIFIED = 0;
   TIMEFRAME_WEEK = 1;
   TIMEFRAME_MONTH = 2;
 }
-
-enum RatingsBand {
-  VERY_GOOD = 0;
-  GOOD = 1;
-  NEUTRAL = 2;
-  POOR = 3;
-  VERY_POOR = 4;
-  INSUFFICIENT_VOTES = 5;
-}

proto/ratings_features_common.proto

@@ -0,0 +1,18 @@
+syntax = "proto3";
+
+package ratings.features.common;
+
+message Rating {
+  string snap_id = 1;
+  uint64 total_votes = 2;
+  RatingsBand ratings_band = 3;
+}
+
+enum RatingsBand {
+  VERY_GOOD = 0;
+  GOOD = 1;
+  NEUTRAL = 2;
+  POOR = 3;
+  VERY_POOR = 4;
+  INSUFFICIENT_VOTES = 5;
+}

src/features/app/infrastructure.rs

@@ -1,8 +1,8 @@
-use crate::app::AppContext;
+use crate::{app::AppContext, features::common::entities::Vote};
 use sqlx::Row;
 use tracing::error;
 
-use super::{entities::Vote, errors::AppError};
+use super::errors::AppError;
 
 pub(crate) async fn get_votes_by_snap_id(
     app_ctx: &AppContext,

src/features/app/mod.rs

@@ -1,4 +1,3 @@
-pub mod entities;
 mod errors;
 mod infrastructure;
 pub mod interface;

src/features/app/use_cases.rs

@@ -1,7 +1,7 @@
-use crate::app::AppContext;
+use crate::{app::AppContext, features::common::entities::Rating};
 use tracing::error;
 
-use super::{entities::Rating, errors::AppError, infrastructure::get_votes_by_snap_id};
+use super::{errors::AppError, infrastructure::get_votes_by_snap_id};
 
 pub async fn get_rating(app_ctx: &AppContext, snap_id: String) -> Result<Rating, AppError> {
     let votes = get_votes_by_snap_id(app_ctx, &snap_id)

src/features/app/entities.rs → src/features/common/entities.rs

@@ -1,6 +1,8 @@
 use sqlx::FromRow;
 
-use super::interface::protobuf;
+pub mod protobuf {
+    tonic::include_proto!("ratings.features.common");
+}
 
 const INSUFFICIENT_VOTES_QUANTITY: usize = 25;
 

src/features/common/mod.rs

@@ -0,0 +1 @@
+pub mod entities;

src/features/mod.rs

@@ -1,2 +1,3 @@
 pub mod app;
+mod common;
 pub mod user;