-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy via ssh #62
Deploy via ssh #62
Conversation
…ull" with consequent file deletion
…e everything working as before
…tion with --ssh and --no-deb parameter
Thanks, this looks excellent! Just please give me a couple of days to try it :-) We might want to redo a bit the logic, I'd like to have a function # Somewhere near the beginning, after parsing the command-line parameters:
if [ ! -z "$SSH_ADDRESS" ] ; then
DEVICE_BACKEND=ssh
else
DEVICE_BACKEND=adb
fi
device () {
ACTION="$1"
shift
${DEVICE_BACKEND}_${ACTION} "$@"
} which will be used like this: device push $DEBS_TARBALL /tmp/repo/ so we will need to have for each action a couple of functions like: ssh_push () {
local last="${!#}"
local argv=( "${@:1:$#-1}" )
scp ${argv[@]} "$SSH_ADDRESS:$last"
}
adb_push () {
adb push "$@"
} What do you think? In any case, it's something that we can do after merging this. |
I didn't try the new SSH backend, but the adb one works like a charm, so let's merge this. Thanks again! |
This PR adds the ability to deploy via ssh.
I've splitted the PR into thematic commits for easier review.
adb
commands in crossbuilder script into functions with a concrete goal (exec_device, push_device, ...), oneadb
type per commit.adb
command call (missing packages checks), to be able to not use adb if --ssh option is passed.Note: This solves #42 and #14 and renders some changes as unnecessary in PR #53.