Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: powershell toolbox improvements #94

Merged

Conversation

lambdaclan
Copy link
Contributor

@lambdaclan lambdaclan commented May 14, 2024

Improve PowerShell toolbox experience

Relates to #11

Description

Improve the UX experience of the new PowerShell toolbox.

Proposed Changes

  • Extend package list with various CLI utils
    • bat
    • eza
    • fd
    • fzf
    • gawk
    • jq
    • ripgrep
    • sed
    • zoxide
  • Fix missing PowerShell modules issue by installing PowerShell as a .NET Global tool
  • Autocomplete for Azure CLI
  • Autocomplete for .NET (dotnet cli)
  • Update README

Notes

The initial launch of pwsh will take longer than usual since some utils need to be downloaded.

@lambdaclan lambdaclan requested a review from castrojo as a code owner May 14, 2024 08:55
castrojo
castrojo previously approved these changes May 14, 2024
@lambdaclan
Copy link
Contributor Author

I think this is now ready for merge. Since the last review I made some adjustments.

I was particularly worried about copying the PowerShell profile to the user home since the user might already have a profile. If used with distrobox without a custom home that could have overridden their custom profile. Now I am correctly using the top level profile that will only get executed if the user does not already have any profiles.

Furthermore, keeping the same thought as above I changed the folder where the shell themes get installed to avoid polluting the user's home directory.

Lastly, I did some config updates to the history viewer to display more results out of the box.

It would be great if someone can test this to get some feedback but for me, it works quite well as an initial template that can be extended later on.

@castrojo castrojo added this pull request to the merge queue May 17, 2024
Merged via the queue into ublue-os:main with commit 25d8692 May 17, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants