refactor: use upstream nvidia defaults #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR this removes code which is duplicating effort of the upstream defaults. Longer version: We submitted a bugfix to upstream negativo17's nvidia driver config to fix power management on optimus laptops. negativo17/nvidia-kmod-common#15 In response @scaronni incorporated another of our changes, setting `NVreg_TemporaryFilePath=/var/tmp`, and suggested some changes for us. Upstream already specifies nvidia-modprobe and nvidia-persistenced, so they need not be specifically called out in our package install. Also nvidia-persistenced service is already default enabled.
bsherman
requested review from
castrojo,
HikariKnight,
KyleGospo,
p5 and
m2Giles
m2Giles
approved these changes
Oct 29, 2024
KyleGospo
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR this removes code which is duplicating effort of the upstream defaults.
Longer version:
We submitted a bugfix to upstream negativo17's nvidia driver config to fix power management on optimus laptops. negativo17/nvidia-kmod-common#15
In response @scaronni incorporated another of our changes, setting
NVreg_TemporaryFilePath=/var/tmp, and suggested some changes for us.Upstream already specifies nvidia-modprobe and nvidia-persistenced, so they need not be specifically called out in our package install. Also nvidia-persistenced service is already default enabled.