Merge branch 'ubiquity:development' into empty-strings

ubiquity · Nov 29, 2024 · 53adeb4 · 53adeb4
2 parents f97330e + b07723d
commit 53adeb4
Show file tree

Hide file tree

Showing 6 changed files with 13,539 additions and 9,808 deletions.
diff --git a/.eslintrc b/.eslintrc
diff --git a/.github/knip.ts b/.github/knip.ts
@@ -3,7 +3,7 @@ import type { KnipConfig } from "knip";
 const config: KnipConfig = {
   entry: ["build/index.ts", ".github/empty-string-checker.ts"],
   project: ["src/**/*.ts"],
-  ignore: ["src/types/config.ts", "**/__mocks__/**", "**/__fixtures__/**"],
+  ignore: ["src/types/config.ts", "**/__mocks__/**", "**/__fixtures__/**", "eslint.config.mjs"],
   ignoreExportsUsedInFile: true,
   // eslint can also be safely ignored as per the docs: https://knip.dev/guides/handling-issues#eslint--jest
   ignoreDependencies: ["eslint-config-prettier", "eslint-plugin-prettier", "@types/jest", "@mswjs/data"],

diff --git a/.github/workflows/cypress-testing.yml b/.github/workflows/cypress-testing.yml
@@ -18,6 +18,7 @@ jobs:
       - name: Cypress run
         uses: cypress-io/github-action@v6
         with:
+          install-command: yarn install
           build: yarn run build
           start: yarn start
         env:

diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,108 @@
+// @ts-check
+import eslint from "@eslint/js";
+import tsEslint from "typescript-eslint";
+import sonarjs from "eslint-plugin-sonarjs";
+import checkFile from "eslint-plugin-check-file";
+
+export default tsEslint.config({
+  plugins: {
+    "@typescript-eslint": tsEslint.plugin,
+    "check-file": checkFile,
+  },
+  ignores: ["**/*.js", ".github/**.ts"],
+  extends: [eslint.configs.recommended, ...tsEslint.configs.recommended, sonarjs.configs.recommended],
+  languageOptions: {
+    parser: tsEslint.parser,
+    parserOptions: {
+      project: ["./tsconfig.json"],
+      allowDefaultProject: ["*.mjs"],
+      tsconfigRootDir: import.meta.dirname,
+    },
+  },
+  rules: {
+    "check-file/filename-naming-convention": [
+      "error",
+      {
+        "**/*.{js,ts}": "+([-._a-z0-9])",
+      },
+    ],
+    "prefer-arrow-callback": ["warn", { allowNamedFunctions: true }],
+    "func-style": ["warn", "declaration", { allowArrowFunctions: false }],
+    "@typescript-eslint/no-floating-promises": "error",
+    "@typescript-eslint/no-non-null-assertion": "error",
+    "constructor-super": "error",
+    "no-invalid-this": "off",
+    "@typescript-eslint/no-invalid-this": "error",
+    "no-restricted-syntax": ["error", "ForInStatement"],
+    "use-isnan": "error",
+    "no-unneeded-ternary": "error",
+    "no-nested-ternary": "error",
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        args: "after-used",
+        ignoreRestSiblings: true,
+        vars: "all",
+        varsIgnorePattern: "^_",
+        argsIgnorePattern: "^_",
+      },
+    ],
+    "@typescript-eslint/await-thenable": "error",
+    "@typescript-eslint/no-misused-new": "error",
+    "@typescript-eslint/restrict-plus-operands": "error",
+    "sonarjs/no-all-duplicated-branches": "error",
+    "sonarjs/no-collection-size-mischeck": "error",
+    "sonarjs/no-duplicated-branches": "error",
+    "sonarjs/no-element-overwrite": "error",
+    "sonarjs/no-identical-conditions": "error",
+    "sonarjs/no-identical-expressions": "error",
+    "@typescript-eslint/naming-convention": [
+      "error",
+      {
+        selector: "interface",
+        format: ["StrictPascalCase"],
+        custom: { regex: "^I[A-Z]", match: false },
+      },
+      {
+        selector: "memberLike",
+        modifiers: ["private"],
+        format: ["strictCamelCase"],
+        leadingUnderscore: "require",
+      },
+      {
+        selector: "typeLike",
+        format: ["StrictPascalCase"],
+      },
+      {
+        selector: "typeParameter",
+        format: ["StrictPascalCase"],
+        prefix: ["T"],
+      },
+      {
+        selector: "variable",
+        format: ["strictCamelCase", "UPPER_CASE"],
+        leadingUnderscore: "allow",
+        trailingUnderscore: "allow",
+      },
+      {
+        selector: "variable",
+        modifiers: ["destructured"],
+        format: null,
+      },
+      {
+        selector: "variable",
+        types: ["boolean"],
+        format: ["StrictPascalCase"],
+        prefix: ["is", "should", "has", "can", "did", "will", "does"],
+      },
+      {
+        selector: "variableLike",
+        format: ["strictCamelCase"],
+      },
+      {
+        selector: ["function", "variable"],
+        format: ["strictCamelCase"],
+      },
+    ],
+  },
+});
diff --git a/package.json b/package.json
@@ -44,16 +44,12 @@
     "@octokit/rest": "^21.0.2",
     "@types/jest": "29.5.12",
     "@types/node": "^20.11.19",
-    "@typescript-eslint/eslint-plugin": "^7.0.1",
-    "@typescript-eslint/parser": "^7.0.1",
     "cspell": "^8.4.0",
     "cypress": "13.6.6",
     "esbuild": "^0.20.1",
-    "eslint": "^8.56.0",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-filename-rules": "^1.3.1",
-    "eslint-plugin-prettier": "^5.1.3",
-    "eslint-plugin-sonarjs": "^2.0.3",
+    "eslint": "9.14.0",
+    "eslint-plugin-check-file": "^2.8.0",
+    "eslint-plugin-sonarjs": "^2.0.4",
     "husky": "^9.0.11",
     "jest": "29.7.0",
     "jest-junit": "16.0.0",
@@ -65,7 +61,8 @@
     "simple-git": "^3.27.0",
     "ts-jest": "29.1.2",
     "tsx": "^4.7.1",
-    "typescript": "^5.3.3"
+    "typescript": "^5.3.3",
+    "typescript-eslint": "^8.16.0"
   },
   "lint-staged": {
     "*.ts": [