Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: offer new fallback intl mastercard SKU 18732 #362

Merged
merged 15 commits into from
Dec 13, 2024

Conversation

EresDev
Copy link
Contributor

@EresDev EresDev commented Dec 10, 2024

Resolves #349

Other than the addition of the new mastercard 18732, it has following improvements.

  • Added some trusted and reliable RPCs back as a backup for backend if RPC handler crashes. It goes crazy sometimes. e.g. couldn't resolve DNS of an rpcs and crashes the whole process
  • show product SKU on UI with the card, will be helpful for troubleshooting if there is a problem.

How to test?

  • fill .env vars (also setup wallets, funding wallet, approval, beneficiary wallet with uusd token for testing and xdai for gas)
  • fill wrangler.toml with production keys of Reloadly
  • yarn build && yarn start
  • your IP location should be South Korea or any other country that support 18732 but doesn't have their country specific card available.
  • if you want the permit amount to go to your wallet for testing instead of the treasury, change the treasury address at /shared/constants.ts

NOTE: All orders with production API keys of Reloadly will deduct the real balance from Reloadly.

QA

qa.mp4

/ubiquity-dollar Location: South Korea

Screenshot_20241213_010128

/ubiquity-dollar Location: Germany

Screenshot_20241212_165301

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Dec 11, 2024

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Preview Deployment
9e22f50a45b68151ceaeb66d01e335148d85a114

@EresDev EresDev requested review from 0x4007 and rndquu December 12, 2024 16:40
@EresDev EresDev marked this pull request as ready for review December 12, 2024 16:40
@EresDev EresDev requested a review from Keyrxng as a code owner December 12, 2024 16:40
@rndquu rndquu requested review from rndquu and removed request for rndquu December 13, 2024 08:20
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, South Korea is covered now

@0x4007
Copy link
Member

0x4007 commented Dec 13, 2024

image

@rndquu
Copy link
Member

rndquu commented Dec 13, 2024

Cloudflare deployment previews work in reloadly sandbox environment, in order to QA this PR for real gift card you need to either run locally either merge and check how it works

@0x4007 0x4007 merged commit 9e22f50 into ubiquity:development Dec 13, 2024
4 checks passed
@EresDev
Copy link
Contributor Author

EresDev commented Dec 17, 2024

@0x4007
I hope things worked smoothly. You should also test redeeming the card if you are hoping to present redeeming them. You can buy a small amount card 6.12$ price card, or you can use one I bought. I didn't redeem it. Both cards redeem codes I bought for testing are present in Gift card google drive file that you already have link to. You should test redeeming 18732 one from South Korea.

Also please note that the card may change if another local card of South Korea becomes available in future, though less likely as I have not seen any local card for South Korea on Reloadly.

@0x4007
Copy link
Member

0x4007 commented Dec 18, 2024

Thank you will test soon. I vaguely recall something about card issuing limits, which is why we choose to use geographically restricted cards over general international cards. What's our issuing limits looking like for this "South Korean" card?

@EresDev
Copy link
Contributor Author

EresDev commented Dec 19, 2024

Thank you will test soon. I vaguely recall something about card issuing limits, which is why we choose to use geographically restricted cards over general international cards. What's our issuing limits looking like for this "South Korean" card?

There was no strict limit but more of theoretical limit. Here is a quote from Reloadly support when I asked them if we only offer international cards to all users because they support large list of countries. They replied:

Program manager recommended us to push purchase by country. I don't know your volume at this moment, if it is 1-2k month may be doesnt matter but if it is few 100ks then better to use proper skus

So, upto 1-2k$ per month is okay for these international cards. It will be concerning if we cross this limit. However, if we have a large volume of international card minting for specific country, we can also ask them to offer local card for that country, as they said:

The countries we activated are the most used ones.. we can enable the rest based on feedback. You need to mention which countries you will be using from the list. Simply. Let's not complicate the process

so if we have large amount of minting from south korea, we can request them to offer card specific to south korea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for gift card with SKU 18732
3 participants