-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: offer new fallback intl mastercard SKU 18732 #362
Conversation
|
will help with troubleshooting exact card if mint fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, South Korea is covered now
Cloudflare deployment previews work in reloadly sandbox environment, in order to QA this PR for real gift card you need to either run locally either merge and check how it works |
@0x4007 Also please note that the card may change if another local card of South Korea becomes available in future, though less likely as I have not seen any local card for South Korea on Reloadly. |
Thank you will test soon. I vaguely recall something about card issuing limits, which is why we choose to use geographically restricted cards over general international cards. What's our issuing limits looking like for this "South Korean" card? |
There was no strict limit but more of theoretical limit. Here is a quote from Reloadly support when I asked them if we only offer international cards to all users because they support large list of countries. They replied:
So, upto 1-2k$ per month is okay for these international cards. It will be concerning if we cross this limit. However, if we have a large volume of international card minting for specific country, we can also ask them to offer local card for that country, as they said:
so if we have large amount of minting from south korea, we can request them to offer card specific to south korea. |
Resolves #349
Other than the addition of the new mastercard 18732, it has following improvements.
How to test?
NOTE: All orders with production API keys of Reloadly will deduct the real balance from Reloadly.
QA
qa.mp4
/ubiquity-dollar Location: South Korea
/ubiquity-dollar Location: Germany